From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Peter Wu <peter@lekensteyn•nl>, git@vger•kernel.org
Subject: Re: [RFC] [PATCH] remote: add new --fetch option for set-url
Date: Wed, 19 Nov 2014 12:29:47 -0800 [thread overview]
Message-ID: <xmqq61ebrl1g.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141119190800.GB9908@peff.net> (Jeff King's message of "Wed, 19 Nov 2014 14:08:00 -0500")
Jeff King <peff@peff•net> writes:
> I dunno. I guess that is more convenient, but it seems like a lot of
> code for a very marginal use case. But more importantly, I'm a little
> worried that the presence of --fetch creates confusion about what
> set-url without a --fetch or --push does. That is, it implies to me
> that:
>
> git remote add gh old-url
> git remote set-url gh --push push-url
> git remote set-url gh new-url
>
> would replace both the "url" _and_ "pushurl" values in the third step,
> since we did not specify --fetch. But it is in fact identical whether
> you run it with "--fetch" or not. That is, it creates a weirdly
> non-orthogonal interface.
Yes, the semantics the updated code gives feel very strange. I
wouldn't be able to write a three-line summary in the release notes
to advertise what good this new feature brings to users myself.
next prev parent reply other threads:[~2014-11-19 20:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 15:18 [RFC] [PATCH] remote: add new --fetch option for set-url Peter Wu
2014-11-19 19:08 ` Jeff King
2014-11-19 19:42 ` Peter Wu
2014-11-19 20:17 ` Jeff King
2014-11-19 20:48 ` Peter Wu
2014-11-19 20:29 ` Junio C Hamano [this message]
2014-11-19 20:52 ` Peter Wu
2014-11-19 21:00 ` Junio C Hamano
2014-11-19 20:58 ` Junio C Hamano
2014-11-19 21:18 ` Junio C Hamano
2014-11-19 21:28 ` Peter Wu
2014-11-24 21:45 ` Peter Wu
2014-11-24 22:04 ` Junio C Hamano
2014-11-24 22:16 ` Peter Wu
2014-11-24 22:22 ` Jeff King
2014-11-24 22:47 ` Peter Wu
2014-11-24 22:54 ` Jeff King
2014-11-24 23:05 ` Junio C Hamano
2014-11-24 23:27 ` Peter Wu
2014-11-25 4:08 ` Jeff King
2014-11-25 4:55 ` Junio C Hamano
2014-11-25 5:01 ` Jeff King
[not found] ` <CAPc5daWh4hnKsTMpaW-TvCmVDfU+rzCezrAHcLgXDG6RVvzXHA@mail.gmail.com>
2014-11-25 11:43 ` Peter Wu
2014-11-25 11:36 ` Peter Wu
2014-11-29 13:31 ` Philip Oakley
2014-12-02 17:45 ` Peter Wu
2014-12-02 23:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61ebrl1g.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=peter@lekensteyn$(echo .)nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox