From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: David Michael <fedora.dm0@gmail•com>,
Eric Sunshine <sunshine@sunshineco•com>,
Git List <git@vger•kernel.org>
Subject: Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule
Date: Mon, 27 Oct 2014 10:42:21 -0700 [thread overview]
Message-ID: <xmqq61f5flz6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141027051705.GC2996@peff.net> (Jeff King's message of "Sun, 26 Oct 2014 22:17:05 -0700")
Jeff King <peff@peff•net> writes:
> On Sun, Oct 26, 2014 at 02:54:56PM -0400, David Michael wrote:
>
>> Yes, the compiler refuses to run by default when a "-L" option occurs
>> after a source/object file. It tries to interpret it as another file
>> name and fails.
>
> Yeah, I think I have seen similar behavior before, but it has been long
> enough that I no longer remember the compiler in use.
>
>> I believe I can work around the error with an "export _C89_CCMODE=1",
>> but I thought I'd send the patch since this is the only occurrence of
>> the problem, and the argument order is inconsistent with other linker
>> commands in the file.
>
> I don't think working around it makes sense. That would fix your case,
> but nobody else's (though given how long it has been that way without
> complaints, I suspect any other compilers this picky may have died off).
I think you meant s/nobody else's/breaks &/;
With that, I agree with your assessment. The diff itself is
probably fine as-is (I didn't look at it for more than 10 seconds,
though ;-). And I agree that it needs to be better explained.
>> Do you want me to resend the patch and reference the IBM documentation
>> in the message?
>
> I don't think you need to. More interesting than documentation is the
> real-world breakage you experienced and the analysis of the situation.
> I'd be fine taking the patch as-is, or if changing anything, mentioning
> the failure mode in the commit message.
>
> -Peff
next prev parent reply other threads:[~2014-10-27 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:33 [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule David Michael
2014-10-26 17:45 ` Eric Sunshine
2014-10-26 18:35 ` Jeff King
2014-10-26 18:54 ` David Michael
2014-10-27 5:17 ` Jeff King
2014-10-27 17:42 ` Junio C Hamano [this message]
2014-10-28 22:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61f5flz6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=fedora.dm0@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox