From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v3 1/2] Push the NATIVE_CRLF Makefile variable to C and added a test for native.
Date: Tue, 02 Sep 2014 12:03:05 -0700 [thread overview]
Message-ID: <xmqq61h526c6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54024473.4040709@web.de> ("Torsten Bögershausen"'s message of "Sat, 30 Aug 2014 23:38:59 +0200")
Torsten Bögershausen <tboegi@web•de> writes:
> From: Pat Thoyts <patthoyts@users•sourceforge.net>
>
> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
> incorrectly set on Mingw git. However, the Makefile variable is not
> propagated to the C preprocessor and results in no change. This patch
> pushes the definition to the C code and adds a test to validate that
> when core.eol as native is crlf, we actually normalize text files to this
> line ending convention when core.autocrlf is false.
>
> Signed-off-by: Pat Thoyts <patthoyts@users•sourceforge.net>
> Signed-off-by: Stepan Kasal <kasal@ucw•cz>
> Signed-off-by: Torsten Bögershausen <tboegi@web•de>
> ---
> This mini series mainly updates git.git with patches from msysgit:
> Patch 1 is taken "as is",
> Patch 2 is taken from msysgit "nearly as is": the broken && chain
> had been fixed.
Shouldn't Patch 1 also be made "nearly as is" to fix the same?
prev parent reply other threads:[~2014-09-02 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 21:38 [PATCH v3 1/2] Push the NATIVE_CRLF Makefile variable to C and added a test for native Torsten Bögershausen
2014-09-02 19:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61h526c6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox