From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
Lars Schneider <larsxschneider@gmail•com>,
git@vger•kernel.org
Subject: Re: [PATCH v1] travis-ci: build and test Git on Windows
Date: Thu, 23 Mar 2017 12:15:58 -0700 [thread overview]
Message-ID: <xmqq7f3fdcsx.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170323180134.geoyvq7qbm5vujo6@sigill.intra.peff.net> (Jeff King's message of "Thu, 23 Mar 2017 14:01:34 -0400")
Jeff King <peff@peff•net> writes:
> I think both Junio and I have access to the Travis config. Travis does
> have a "this is secret" flag for setup config. But I think we'd need to
> verify that running the Travis build does not leak the variable in any
> other way.
I am not sure if I want to "Authorize application" at the GitHub
site to give Travis that broad set of permissions, though. That is
why I do not "log in with GitHub" to Travis.
I just logged into Travis and it seems to me that git/git is set to
build branch updates (which sounds sensible) and also is set to
build pull request updates. That somehow sounds like a dangerous
mix with the "secret environment variables" thing, at least to me.
> For instance, if it's in the environment, can I push up a branch that
> does "set | grep GFW_CI_TOKEN", open a PR, and see it? I don't know the
> answer.
next prev parent reply other threads:[~2017-03-23 19:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 6:56 [PATCH v1] travis-ci: build and test Git on Windows Lars Schneider
2017-03-22 15:49 ` Johannes Schindelin
2017-03-23 18:19 ` Lars Schneider
2017-03-22 19:29 ` Junio C Hamano
2017-03-23 16:22 ` Johannes Schindelin
2017-03-23 18:01 ` Jeff King
2017-03-23 19:12 ` Junio C Hamano
2017-03-23 19:17 ` Jeff King
2017-03-23 19:26 ` Lars Schneider
2017-03-23 19:30 ` Junio C Hamano
2017-03-23 19:36 ` Lars Schneider
2017-03-23 20:10 ` Junio C Hamano
2017-03-23 19:38 ` Jeff King
2017-03-23 20:00 ` Lars Schneider
2017-03-23 20:20 ` Jeff King
2017-03-23 20:30 ` Junio C Hamano
2017-03-23 20:41 ` Jeff King
2017-03-23 20:39 ` Lars Schneider
2017-03-23 20:42 ` Jeff King
2017-03-24 23:50 ` Johannes Schindelin
2017-03-23 21:04 ` Samuel Lijin
2017-03-23 19:15 ` Junio C Hamano [this message]
2017-03-23 18:23 ` Lars Schneider
2017-03-23 20:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7f3fdcsx.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox