From: Junio C Hamano <gitster@pobox•com>
To: Lars Schneider <larsxschneider@gmail•com>
Cc: git@vger•kernel.org, Johannes.Schindelin@gmx•de, peff@peff•net
Subject: Re: [PATCH v1] travis-ci: build and test Git on Windows
Date: Thu, 23 Mar 2017 13:16:48 -0700 [thread overview]
Message-ID: <xmqqbmsrbvf3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170322065612.18797-1-larsxschneider@gmail.com> (Lars Schneider's message of "Wed, 22 Mar 2017 07:56:12 +0100")
Lars Schneider <larsxschneider@gmail•com> writes:
> Things, that would need to be done:
> * Someone with write access to https://travis-ci.org/git/git would need
> to add the secret token as "GFW_CI_TOKEN" variable in the TravisCI
> repository setting [1]. Afterwards the build should just work.
As coordinating the timing of when this happens with the timing when
merging this topic to 'pu' happens is an unnecessary cognitive
burden, can you make a small change to this part:
> + script:
> + - >
> + test "$TRAVIS_REPO_SLUG" != "git/git" ||
Add
test -z "$GFW_CI_TOKEN" ||
here, so that the sript is not run while "Someone with write access"
hasn't got around to doing it.
> + ci/run-windows-build.sh $GFW_CI_TOKEN $TRAVIS_BRANCH $(git rev-parse HEAD)
It would still be a good idea to dq all these $VARIABLE and
$(COMMAND OUTPUT) references, as the script expects three
parameters.
> + ...
> +[ $# -eq 3 ] || (echo "Unexpected number of parameters" && exit 1)
Thanks.
prev parent reply other threads:[~2017-03-23 20:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 6:56 [PATCH v1] travis-ci: build and test Git on Windows Lars Schneider
2017-03-22 15:49 ` Johannes Schindelin
2017-03-23 18:19 ` Lars Schneider
2017-03-22 19:29 ` Junio C Hamano
2017-03-23 16:22 ` Johannes Schindelin
2017-03-23 18:01 ` Jeff King
2017-03-23 19:12 ` Junio C Hamano
2017-03-23 19:17 ` Jeff King
2017-03-23 19:26 ` Lars Schneider
2017-03-23 19:30 ` Junio C Hamano
2017-03-23 19:36 ` Lars Schneider
2017-03-23 20:10 ` Junio C Hamano
2017-03-23 19:38 ` Jeff King
2017-03-23 20:00 ` Lars Schneider
2017-03-23 20:20 ` Jeff King
2017-03-23 20:30 ` Junio C Hamano
2017-03-23 20:41 ` Jeff King
2017-03-23 20:39 ` Lars Schneider
2017-03-23 20:42 ` Jeff King
2017-03-24 23:50 ` Johannes Schindelin
2017-03-23 21:04 ` Samuel Lijin
2017-03-23 19:15 ` Junio C Hamano
2017-03-23 18:23 ` Lars Schneider
2017-03-23 20:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmsrbvf3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox