From: Junio C Hamano <gitster@pobox•com>
To: Andreas Schwab <schwab@suse•de>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic•com>,
git@vger•kernel.org, "Luis R. Rodriguez" <mcgrof@suse•com>,
Jiri Slaby <jslaby@suse•cz>, Jan Kara <jack@suse•cz>
Subject: Re: [PATCH] tag: add -i and --introduced modifier for --contains
Date: Thu, 17 Apr 2014 11:49:25 -0700 [thread overview]
Message-ID: <xmqq7g6neqq2.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87zjjj50eq.fsf@igel.home> (Andreas Schwab's message of "Thu, 17 Apr 2014 19:30:21 +0200")
Andreas Schwab <schwab@suse•de> writes:
> Junio C Hamano <gitster@pobox•com> writes:
> ...
>> When your project does not mind basing the description on rc tags,
>> between v3.4-rc1~192^2~9^2 and v3.5-rc1~120^3~76^2, I am not sure if
>> we would want to say that "the former is not so longer than the
>> latter, so use that", or what kind of heuristics to employ to reach
>> that conclusion. Date-based selection (i.e. earliest first) is one
>> possibility. Tagname-based selection has the issue of having to
>> configure "whose version numbering convention would you use when
>> sorting tags, and how you would tell Git that sorting order rule?"
>
> IMHO git should select based on topology: the first tag that isn't
> contained in any other tag still containing the commit in question, only
> when ambigous it needs to fall back to other criteria.
I think we are in agreement. In the part you chopped from your
quote, I said:
>> For a possible cleaner alternative semantics, see the other message
>> I just sent to the thread.
didn't I?
prev parent reply other threads:[~2014-04-17 18:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 20:58 [PATCH] tag: add -i and --introduced modifier for --contains Luis R. Rodriguez
2014-04-16 22:02 ` Junio C Hamano
2014-04-16 22:35 ` Luis R. Rodriguez
2014-04-17 17:04 ` Junio C Hamano
2014-04-17 22:16 ` Jeff King
2014-04-18 16:26 ` Junio C Hamano
2014-04-22 4:04 ` W. Trevor King
2014-04-18 23:17 ` Luis R. Rodriguez
2014-04-18 23:36 ` Junio C Hamano
2014-04-22 0:38 ` Luis R. Rodriguez
2014-04-22 10:27 ` Jan Kara
2014-04-22 17:58 ` Junio C Hamano
2014-04-17 7:17 ` Andreas Schwab
2014-04-17 17:05 ` Junio C Hamano
2014-04-17 17:30 ` Andreas Schwab
2014-04-17 18:49 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7g6neqq2.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jack@suse$(echo .)cz \
--cc=jslaby@suse$(echo .)cz \
--cc=mcgrof@do-not-panic$(echo .)com \
--cc=mcgrof@suse$(echo .)com \
--cc=schwab@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox