From: Junio C Hamano <gitster@pobox•com>
To: Jan Kara <jack@suse•cz>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic•com>,
git@vger•kernel.org, "Luis R. Rodriguez" <mcgrof@suse•com>,
Jiri Slaby <jslaby@suse•cz>, Andreas Schwab <schwab@suse•de>,
Jeff King <peff@peff•net>
Subject: Re: [PATCH] tag: add -i and --introduced modifier for --contains
Date: Tue, 22 Apr 2014 10:58:08 -0700 [thread overview]
Message-ID: <xmqqppk95jrj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140422102713.GC366@quack.suse.cz> (Jan Kara's message of "Tue, 22 Apr 2014 12:27:13 +0200")
Jan Kara <jack@suse•cz> writes:
> On Thu 17-04-14 10:04:52, Junio C Hamano wrote:
>> So perhaps the rule should be updated to do something like:
>>
>> - find candidate tags that can be used to "describe --contains"
>> the commit A, yielding v3.4, v3.5 (not shown), and v9.0;
>>
>> - among the candidate tags, cull the ones that contain another
>> candidate tag, rejecting v3.5 (not shown) and v9.0;
>>
>> - among the surviving tags, pick the closest.
> ...
> Regarding the strategy what to select when there are several
> remaining tags after first two steps I would prefer to output all such
> tags.
Yes, as I mentioned in another subthread ($gmane/246488), different
projects want different tie-breaking rules at the third step, and
your "show all to give more information to the user" could be
another mode of operation.
I offhand do not think the current name-rev machinery is set up to
compute your variant easily, though.
next prev parent reply other threads:[~2014-04-22 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 20:58 [PATCH] tag: add -i and --introduced modifier for --contains Luis R. Rodriguez
2014-04-16 22:02 ` Junio C Hamano
2014-04-16 22:35 ` Luis R. Rodriguez
2014-04-17 17:04 ` Junio C Hamano
2014-04-17 22:16 ` Jeff King
2014-04-18 16:26 ` Junio C Hamano
2014-04-22 4:04 ` W. Trevor King
2014-04-18 23:17 ` Luis R. Rodriguez
2014-04-18 23:36 ` Junio C Hamano
2014-04-22 0:38 ` Luis R. Rodriguez
2014-04-22 10:27 ` Jan Kara
2014-04-22 17:58 ` Junio C Hamano [this message]
2014-04-17 7:17 ` Andreas Schwab
2014-04-17 17:05 ` Junio C Hamano
2014-04-17 17:30 ` Andreas Schwab
2014-04-17 18:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppk95jrj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jack@suse$(echo .)cz \
--cc=jslaby@suse$(echo .)cz \
--cc=mcgrof@do-not-panic$(echo .)com \
--cc=mcgrof@suse$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=schwab@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox