From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Cc: "Ken Matsui" <ken@kmatsui•me>,
"Jonathan Tan" <jonathantanmy@google•com>,
"Matheus Tavares" <matheus.tavb@gmail•com>,
"Patrick Steinhardt" <ps@pks•im>,
"Martin Ågren" <martin.agren@gmail•com>,
"Glen Choo" <glencbz@gmail•com>, "Victoria Dye" <vdye@github•com>,
"Elijah Newren" <newren@gmail•com>
Subject: Re: [PATCH v3] config: support remote name in includeIf.hasconfig condition
Date: Tue, 03 Dec 2024 16:28:10 +0900 [thread overview]
Message-ID: <xmqq8qsxcjjp.fsf@gitster.g> (raw)
In-Reply-To: <20241020173216.40852-2-ken@kmatsui.me> (Ken Matsui's message of "Sun, 20 Oct 2024 13:32:16 -0400")
Ken Matsui <ken@kmatsui•me> writes:
> Changes in v3:
>
> * Updated the description based on Ramsay's review.
> * Added more tests.
>
> Changes in v2:
>
> * Updated the description based on Kristoffer's review.
This has never seen any serious review since its original iterations
were posted late October. Anybody interested [*]?
Otherwise since it is approaching to be more than a month and a
half old, I am going to mark the topic to be discarded.
Thanks.
[Footnote]
* I ask because apparently I am not interested at all. At least
not yet, with what I saw in the previous postings in this thread.
My take on it is that the "if any remote has this URL" change
earlier did make some sort of sense, but I do not see the utility
of this change. If we need to access both of these two remote
repositories, "to access github, we need these definition, and to
access k.org, we need those, so include them" do make sense, but
because these include do *not* limit their effectiveness upon
which remote each Git operation accesses (i.e. You cannot say
"use this configuration setting while running 'git fetch origin'
but use that other setting while running 'git push github'"), it
does not make much sense to say "if 'origin' is X, then do this",
at least to me.
prev parent reply other threads:[~2024-12-03 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 15:23 [PATCH] config: support remote name in includeIf.hasconfig condition Ken Matsui
2024-10-20 15:33 ` Kristoffer Haugsbakk
2024-10-20 15:43 ` Ken Matsui
2024-10-20 16:01 ` [PATCH v2] " Ken Matsui
2024-10-20 16:21 ` Ramsay Jones
2024-10-20 17:18 ` Ken Matsui
2024-10-20 17:30 ` Ken Matsui
2024-10-20 17:32 ` [PATCH v3] " Ken Matsui
2024-11-06 13:30 ` Ken Matsui
2024-12-03 7:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qsxcjjp.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=glencbz@gmail$(echo .)com \
--cc=jonathantanmy@google$(echo .)com \
--cc=ken@kmatsui$(echo .)me \
--cc=martin.agren@gmail$(echo .)com \
--cc=matheus.tavb@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=vdye@github$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox