public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Elia Pinto <gitter.spiros@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] test-lib-functions.sh: fix the second argument to some helper functions
Date: Thu, 16 Apr 2015 13:31:31 -0700	[thread overview]
Message-ID: <xmqq8udrizmk.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqoamop28y.fsf@anie.imag.fr> (Matthieu Moy's message of "Thu, 16 Apr 2015 16:38:21 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:

> Elia Pinto <gitter.spiros@gmail•com> writes:
>
>> --- a/t/test-lib-functions.sh
>> +++ b/t/test-lib-functions.sh
>> @@ -478,7 +478,7 @@ test_external_without_stderr () {
>>  test_path_is_file () {
>>  	if ! test -f "$1"
>>  	then
>> -		echo "File $1 doesn't exist. $*"
>> +		echo "File $1 doesn't exist. $2"
>>  		false
>>  	fi
>>  }
>> @@ -486,7 +486,7 @@ test_path_is_file () {
>>  test_path_is_dir () {
>>  	if ! test -d "$1"
>>  	then
>> -		echo "Directory $1 doesn't exist. $*"
>> +		echo "Directory $1 doesn't exist. $2"
>>  		false
>>  	fi
>>  }
>
> Sounds straightforwardly correct to me.

Thanks.  This however makes me wonder why you were nominated for
reviewing this patch, though...

next prev parent reply	other threads:[~2015-04-16 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 14:12 [PATCH] test-lib-functions.sh: fix the second argument to some helper functions Elia Pinto
2015-04-16 14:38 ` Matthieu Moy
2015-04-16 20:31   ` Junio C Hamano [this message]
2015-04-20 11:03     ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8udrizmk.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitter.spiros@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox