public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Michael Kebe <michael.kebe@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh
Date: Tue, 27 Jun 2017 09:25:17 -0700	[thread overview]
Message-ID: <xmqqa84t2yaa.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAKKM46uJLu+w-UUFZc1HRar3apAD6Db2KD+GjiNL5v+Q2Ni7hA@mail.gmail.com> (Michael Kebe's message of "Tue, 27 Jun 2017 14:15:43 +0200")

Michael Kebe <michael.kebe@gmail•com> writes:

> Running the test suite on Solaris 11.3 SPARC fails on a test in t1450-fsck.sh.
>
> not ok 60 - fsck --name-objects
> #
> #               rm -rf name-objects &&
> #               git init name-objects &&
> #               (
> #                       cd name-objects &&
> #                       test_commit julius caesar.t &&
> #                       test_commit augustus &&
> #                       test_commit caesar &&
> #                       remove_object $(git rev-parse julius:caesar.t) &&
> #                       test_must_fail git fsck --name-objects >out &&
> #                       tree=$(git rev-parse --verify julius:) &&
> #                       grep "$tree (\(refs/heads/master\|HEAD\)@{[0-9]*}:" out
> #               )
>
> Solaris has /usr/bin/grep and /usr/bin/ggrep. grep is a solaris
> version and ggrep is the GNU grep.

We do not need GNUism, but many tools that come in /usr/bin have
been found unfit.  I thought that Solaris users were expected to set
SANE_TOOL_PATH to point at /usr/xpg[46]/bin to avoid this problem.

Ah, wait, that particular grep may have GNUism.  If you changed it
to

    egrep "$tree \((refs/heads/master|HEAD)@{[0-9]*}:" out

does it make it pass for you?

  reply	other threads:[~2017-06-27 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 12:15 Solaris 11.3 SPARC grep problem with t1450-fsck.sh Michael Kebe
2017-06-27 16:25 ` Junio C Hamano [this message]
2017-06-28  6:00   ` Michael Kebe
2017-06-28 17:15     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa84t2yaa.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=michael.kebe@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox