* Solaris 11.3 SPARC grep problem with t1450-fsck.sh
@ 2017-06-27 12:15 Michael Kebe
2017-06-27 16:25 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Michael Kebe @ 2017-06-27 12:15 UTC (permalink / raw)
To: Git Mailing List
Running the test suite on Solaris 11.3 SPARC fails on a test in t1450-fsck.sh.
not ok 60 - fsck --name-objects
#
# rm -rf name-objects &&
# git init name-objects &&
# (
# cd name-objects &&
# test_commit julius caesar.t &&
# test_commit augustus &&
# test_commit caesar &&
# remove_object $(git rev-parse julius:caesar.t) &&
# test_must_fail git fsck --name-objects >out &&
# tree=$(git rev-parse --verify julius:) &&
# grep "$tree (\(refs/heads/master\|HEAD\)@{[0-9]*}:" out
# )
Solaris has /usr/bin/grep and /usr/bin/ggrep. grep is a solaris
version and ggrep is the GNU grep.
Replacing grep with ggrep in t1450-fsck.sh script the fixes the problem.
I chatted with Ævar and he thinks that the problem is that configure
finds the right grep but it is not properly passed to the tests.
Furthermore I discovered that some tests in t3900-i18n-commit.sh are failing.
e.g.: not ok 17 - ISO-2022-JP should be shown in UTF-8 now
But that's another topic, which I will open once this is fixed.
Greetings
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh
2017-06-27 12:15 Solaris 11.3 SPARC grep problem with t1450-fsck.sh Michael Kebe
@ 2017-06-27 16:25 ` Junio C Hamano
2017-06-28 6:00 ` Michael Kebe
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2017-06-27 16:25 UTC (permalink / raw)
To: Michael Kebe; +Cc: Git Mailing List
Michael Kebe <michael.kebe@gmail•com> writes:
> Running the test suite on Solaris 11.3 SPARC fails on a test in t1450-fsck.sh.
>
> not ok 60 - fsck --name-objects
> #
> # rm -rf name-objects &&
> # git init name-objects &&
> # (
> # cd name-objects &&
> # test_commit julius caesar.t &&
> # test_commit augustus &&
> # test_commit caesar &&
> # remove_object $(git rev-parse julius:caesar.t) &&
> # test_must_fail git fsck --name-objects >out &&
> # tree=$(git rev-parse --verify julius:) &&
> # grep "$tree (\(refs/heads/master\|HEAD\)@{[0-9]*}:" out
> # )
>
> Solaris has /usr/bin/grep and /usr/bin/ggrep. grep is a solaris
> version and ggrep is the GNU grep.
We do not need GNUism, but many tools that come in /usr/bin have
been found unfit. I thought that Solaris users were expected to set
SANE_TOOL_PATH to point at /usr/xpg[46]/bin to avoid this problem.
Ah, wait, that particular grep may have GNUism. If you changed it
to
egrep "$tree \((refs/heads/master|HEAD)@{[0-9]*}:" out
does it make it pass for you?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh
2017-06-27 16:25 ` Junio C Hamano
@ 2017-06-28 6:00 ` Michael Kebe
2017-06-28 17:15 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Michael Kebe @ 2017-06-28 6:00 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Git Mailing List
2017-06-27 18:25 GMT+02:00 Junio C Hamano <gitster@pobox•com>:
> Ah, wait, that particular grep may have GNUism. If you changed it
> to
>
> egrep "$tree \((refs/heads/master|HEAD)@{[0-9]*}:" out
>
> does it make it pass for you?
Yes, this is working.
Greetings
Michael
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Solaris 11.3 SPARC grep problem with t1450-fsck.sh
2017-06-28 6:00 ` Michael Kebe
@ 2017-06-28 17:15 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2017-06-28 17:15 UTC (permalink / raw)
To: Michael Kebe; +Cc: Git Mailing List
Michael Kebe <michael.kebe@gmail•com> writes:
> 2017-06-27 18:25 GMT+02:00 Junio C Hamano <gitster@pobox•com>:
>> Ah, wait, that particular grep may have GNUism. If you changed it
>> to
>>
>> egrep "$tree \((refs/heads/master|HEAD)@{[0-9]*}:" out
>>
>> does it make it pass for you?
>
> Yes, this is working.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-28 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-27 12:15 Solaris 11.3 SPARC grep problem with t1450-fsck.sh Michael Kebe
2017-06-27 16:25 ` Junio C Hamano
2017-06-28 6:00 ` Michael Kebe
2017-06-28 17:15 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox