From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: larsxschneider@gmail•com, git@vger•kernel.org, luke@diamand•org
Subject: Re: [PATCH] git-p4: add "--path-encoding" option
Date: Mon, 31 Aug 2015 13:09:55 -0700 [thread overview]
Message-ID: <xmqqa8t7usmk.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <55E4A965.8040305@web.de> ("Torsten Bögershausen"'s message of "Mon, 31 Aug 2015 21:22:13 +0200")
Torsten Bögershausen <tboegi@web•de> writes:
> On 2015-08-31 19.40, Junio C Hamano wrote:
>> larsxschneider@gmail•com writes:
>
>>> +test_expect_success 'Create a repo containing cp1251 encoded paths' '
>>> + cd "$cli" &&
>>> +
>>> + FILENAME="$(echo "a-¤_o-¶_u-¼.txt" | iconv -f utf-8 -t cp1252)" &&
>> ...
> Using file names and iconv like this may not be portable:
> - cp1252 may be called CP1252 (or may not be available)
"git grep 'cp[0-9]' t/" does tell us that we refrain from using them
and I am sure the portability worries is a big reason. Thank you
for pointing it out.
> - reading from stdin is not necessarily supported by iconv
"git grep '| iconv' t/" tells me that this is irrelevant; we already
heavily depend on it.
> - creating files in CP1252 may not be supported under Mac OS
> (Not sure about Windows)
The same as the first point, which is a good thing to worry about.
> One solution could be to use ISO-8859-1, convert into UTF-8,
> and "convert into UTF-8" one more time.
I do not quite get it; do you need to do anything more than just
replacing cp1252 with iso-8859-1 in the patch being discussed?
prev parent reply other threads:[~2015-08-31 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 15:40 [PATCH] git-p4: add "--path-encoding" option larsxschneider
2015-08-31 15:40 ` larsxschneider
2015-08-31 17:40 ` Junio C Hamano
2015-08-31 19:22 ` Torsten Bögershausen
2015-08-31 20:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8t7usmk.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larsxschneider@gmail$(echo .)com \
--cc=luke@diamand$(echo .)org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox