From: Junio C Hamano <gitster@pobox•com>
To: Duy Nguyen <pclouds@gmail•com>
Cc: Jens Lehmann <Jens.Lehmann@web•de>,
Craig Silverstein <csilvers@khanacademy•org>,
Git Mailing List <git@vger•kernel.org>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH] git-new-workdir: support submodules
Date: Wed, 28 Jan 2015 12:18:37 -0800 [thread overview]
Message-ID: <xmqqbnlihd5u.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACsJy8C1zBawTbeNcr+JtzTwHupb8jpivL-8Tvr=zjAAUhMLLw@mail.gmail.com> (Duy Nguyen's message of "Wed, 28 Jan 2015 17:53:43 +0700")
Duy Nguyen <pclouds@gmail•com> writes:
> On Wed, Jan 28, 2015 at 5:50 PM, Duy Nguyen <pclouds@gmail•com> wrote:
>> For git-new-workdir.sh, perhaps we can teach include.path to make
>> config.local path relative to where the config symlink is, not where
>> the symlink target is.
>
> Ignore this part. I originally wanted to use include.path to load
> config.local, but there was an easier way. With this patch, I think
> config.local is already per worktree that is created by
> git-new-workdir.sh.
I think this may give us a cleaner approach to support a "keep
multiple working trees from the same project that are configured
differently" setting.
I am not sure how well it meshes to call this as ".local" with the
"--local" option of "git config" (read: "local" is a loaded word,
and the way we have used it have been "per repository", but now you
are using it to mean "per working tree" that is finer grained),
though.
I hope that there aren't people that are crazy enough to bind the
same repository to two different places in the top-level project,
and insist that we (re)use the submodule repository ;-).
next prev parent reply other threads:[~2015-01-28 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 21:51 [PATCH] git-new-workdir: support submodules Craig Silverstein
2015-01-24 0:48 ` Craig Silverstein
2015-01-24 1:37 ` Junio C Hamano
2015-01-25 1:47 ` Craig Silverstein
2015-01-26 4:05 ` Junio C Hamano
2015-01-26 4:57 ` Craig Silverstein
2015-01-26 5:39 ` Junio C Hamano
2015-01-27 17:35 ` Jens Lehmann
2015-01-28 10:50 ` Duy Nguyen
2015-01-28 10:53 ` Duy Nguyen
2015-01-28 20:18 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 2:10 Craig Silverstein
2014-12-23 19:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbnlihd5u.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Jens.Lehmann@web$(echo .)de \
--cc=csilvers@khanacademy$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox