From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: "Git Mailing List" <git@vger•kernel.org>,
"Johannes Schindelin" <johannes.schindelin@gmx•de>,
"Torsten Bögershausen" <tboegi@web•de>
Subject: Re: https://travis-ci.org/git/git/builds/
Date: Thu, 11 May 2017 18:51:14 +0900 [thread overview]
Message-ID: <xmqqd1bfafhp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX5tf9seb0mCR+UOUCk3jA-L47C9qowSnBzzNq9eZ4+H+g@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 11 May 2017 10:11:33 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> On Thu, May 11, 2017 at 9:46 AM, Junio C Hamano <gitster@pobox•com> wrote:
>> I was hoping that by ejecting a few topics out of 'pu', we could
>> finally see all the build jobs pass their tests under Travis CI.
>> Unfortunately, no such luck. It seems that we have some new issues
>> with Gettext-Poison build/test after updates to t0027. Also the
>> updated compatibility regexp thing taken from gawk is not liked by
>> the Windows compiler.
>>
>> Not all of these may not be new issues, but nevertheless, it would
>> be nice if we can see all build jobs succeed every once in a while,
>> not just for the three stable integration branches but also for 'pu'
>> ;-)
>
> The gettext part is my bad, I never tested with EXPENSIVE which
> Torsten removed, so now the test runs & fails under poison.
>
> This trivial fixup makes it pass:
>
> diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> index effc3db0d5..deb3ae7813 100755
> --- a/t/t0027-auto-crlf.sh
> +++ b/t/t0027-auto-crlf.sh
> @@ -69,7 +69,7 @@ check_warning () {
> *) echo >&2 "Illegal 1": "$1" ; return false ;;
> esac
> grep "will be replaced by" "$2" | sed -e "s/\(.*\) in [^
> ]*$/\1/" | uniq >"$2".actual
> - test_cmp "$2".expect "$2".actual
> + test_i18ncmp "$2".expect "$2".actual
> }
>
> commit_check_warn () {
>
> Can you please squash that into my patch?
Sure. Thanks for a quick response.
prev parent reply other threads:[~2017-05-11 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 7:46 https://travis-ci.org/git/git/builds/ Junio C Hamano
2017-05-11 8:11 ` https://travis-ci.org/git/git/builds/ Ævar Arnfjörð Bjarmason
2017-05-11 9:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1bfafhp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox