* https://travis-ci.org/git/git/builds/
@ 2017-05-11 7:46 Junio C Hamano
2017-05-11 8:11 ` https://travis-ci.org/git/git/builds/ Ævar Arnfjörð Bjarmason
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2017-05-11 7:46 UTC (permalink / raw)
To: git
Cc: Johannes Schindelin, Ævar Arnfjörð Bjarmason,
Torsten Bögershausen
I was hoping that by ejecting a few topics out of 'pu', we could
finally see all the build jobs pass their tests under Travis CI.
Unfortunately, no such luck. It seems that we have some new issues
with Gettext-Poison build/test after updates to t0027. Also the
updated compatibility regexp thing taken from gawk is not liked by
the Windows compiler.
Not all of these may not be new issues, but nevertheless, it would
be nice if we can see all build jobs succeed every once in a while,
not just for the three stable integration branches but also for 'pu'
;-)
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: https://travis-ci.org/git/git/builds/
2017-05-11 7:46 https://travis-ci.org/git/git/builds/ Junio C Hamano
@ 2017-05-11 8:11 ` Ævar Arnfjörð Bjarmason
2017-05-11 9:51 ` https://travis-ci.org/git/git/builds/ Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2017-05-11 8:11 UTC (permalink / raw)
To: Junio C Hamano
Cc: Git Mailing List, Johannes Schindelin, Torsten Bögershausen
On Thu, May 11, 2017 at 9:46 AM, Junio C Hamano <gitster@pobox•com> wrote:
> I was hoping that by ejecting a few topics out of 'pu', we could
> finally see all the build jobs pass their tests under Travis CI.
> Unfortunately, no such luck. It seems that we have some new issues
> with Gettext-Poison build/test after updates to t0027. Also the
> updated compatibility regexp thing taken from gawk is not liked by
> the Windows compiler.
>
> Not all of these may not be new issues, but nevertheless, it would
> be nice if we can see all build jobs succeed every once in a while,
> not just for the three stable integration branches but also for 'pu'
> ;-)
The gettext part is my bad, I never tested with EXPENSIVE which
Torsten removed, so now the test runs & fails under poison.
This trivial fixup makes it pass:
diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
index effc3db0d5..deb3ae7813 100755
--- a/t/t0027-auto-crlf.sh
+++ b/t/t0027-auto-crlf.sh
@@ -69,7 +69,7 @@ check_warning () {
*) echo >&2 "Illegal 1": "$1" ; return false ;;
esac
grep "will be replaced by" "$2" | sed -e "s/\(.*\) in [^
]*$/\1/" | uniq >"$2".actual
- test_cmp "$2".expect "$2".actual
+ test_i18ncmp "$2".expect "$2".actual
}
commit_check_warn () {
Can you please squash that into my patch?
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: https://travis-ci.org/git/git/builds/
2017-05-11 8:11 ` https://travis-ci.org/git/git/builds/ Ævar Arnfjörð Bjarmason
@ 2017-05-11 9:51 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2017-05-11 9:51 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason
Cc: Git Mailing List, Johannes Schindelin, Torsten Bögershausen
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> On Thu, May 11, 2017 at 9:46 AM, Junio C Hamano <gitster@pobox•com> wrote:
>> I was hoping that by ejecting a few topics out of 'pu', we could
>> finally see all the build jobs pass their tests under Travis CI.
>> Unfortunately, no such luck. It seems that we have some new issues
>> with Gettext-Poison build/test after updates to t0027. Also the
>> updated compatibility regexp thing taken from gawk is not liked by
>> the Windows compiler.
>>
>> Not all of these may not be new issues, but nevertheless, it would
>> be nice if we can see all build jobs succeed every once in a while,
>> not just for the three stable integration branches but also for 'pu'
>> ;-)
>
> The gettext part is my bad, I never tested with EXPENSIVE which
> Torsten removed, so now the test runs & fails under poison.
>
> This trivial fixup makes it pass:
>
> diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> index effc3db0d5..deb3ae7813 100755
> --- a/t/t0027-auto-crlf.sh
> +++ b/t/t0027-auto-crlf.sh
> @@ -69,7 +69,7 @@ check_warning () {
> *) echo >&2 "Illegal 1": "$1" ; return false ;;
> esac
> grep "will be replaced by" "$2" | sed -e "s/\(.*\) in [^
> ]*$/\1/" | uniq >"$2".actual
> - test_cmp "$2".expect "$2".actual
> + test_i18ncmp "$2".expect "$2".actual
> }
>
> commit_check_warn () {
>
> Can you please squash that into my patch?
Sure. Thanks for a quick response.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-11 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 7:46 https://travis-ci.org/git/git/builds/ Junio C Hamano
2017-05-11 8:11 ` https://travis-ci.org/git/git/builds/ Ævar Arnfjörð Bjarmason
2017-05-11 9:51 ` https://travis-ci.org/git/git/builds/ Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox