From: Junio C Hamano <gitster@pobox•com>
To: Heiko Voigt <hvoigt@hvoigt•net>
Cc: git@vger•kernel.org
Subject: Re: What's cooking in git.git (Aug 2014, #03; Wed, 20)
Date: Thu, 21 Aug 2014 10:08:41 -0700 [thread overview]
Message-ID: <xmqqd2btsrc6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140821125111.GA68724@book.hvoigt.net> (Heiko Voigt's message of "Thu, 21 Aug 2014 14:51:11 +0200")
Heiko Voigt <hvoigt@hvoigt•net> writes:
> On Wed, Aug 20, 2014 at 04:17:33PM -0700, Junio C Hamano wrote:
>> * hv/submodule-config (2014-06-30) 4 commits
>> (merged to 'next' on 2014-07-17 at 5e0ce45)
>> + do not die on error of parsing fetchrecursesubmodules option
>> + use new config API for worktree configurations of submodules
>> + extract functions for submodule config set and lookup
>> + implement submodule config cache for lookup of submodule names
>>
>> Will cook in 'next'.
>
> While using the config API for implementing my recursive fetch. I
> discovered a bug in my API here. In submodule_from_name() the lookup of
> the gitmodule sha1 is missing. So currently you would have to pass in
> the gitmodule sha1 instead of the commit sha1 as documented. I will
> extend the test and fix this.
OK, I do not mind temporarily kicking this back to 'pu', so that you
can replace these wholesale instead of doing an incremental patch on
top, when we rewind 'next' in a few days.
Thanks.
prev parent reply other threads:[~2014-08-21 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 23:17 What's cooking in git.git (Aug 2014, #03; Wed, 20) Junio C Hamano
2014-08-21 8:19 ` Jeff King
2014-08-21 12:51 ` Heiko Voigt
2014-08-21 17:08 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2btsrc6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox