From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org, Lasse Makholm <lasse.makholm@gmail•com>
Subject: Re: [PATCH 1/2] t0003: do not chdir the whole test process
Date: Thu, 06 Feb 2014 13:26:39 -0800 [thread overview]
Message-ID: <xmqqd2j0x78w.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140206203101.GX30398@google.com> (Jonathan Nieder's message of "Thu, 6 Feb 2014 12:31:01 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
> For a while I've been wanting to teach GIT_SKIP_TESTS not to skip
> tests with 'setup' or 'set up' in their name, but I never got around
> to it.
Yeah, that would be a good thing. As part of doing so, we might
want to come up with a way to test the tests, randomly skipping
pieces that are not "setup" and find ones that break the later tests
when skipped, and mark test scripts that fail such a test for fixing.
> If I try to skip the setup test this patch touches, then there
> is no bare.git and lots of later tests fail. Perhaps it would be
> better for each test to do
>
> rm -fr bare.git &&
> git clone --bare . bare.git &&
> (
> cd bare.git &&
> ...
> )
>
> for itself to make the state easier to think about.
That is a better and worse way to do it at the same time ;-) It
definitely is better from maintainability POV to keep each test as
independent as possible. It however also is worse if it forces us
to be repetitive X-<.
> On the other hand I agree that the 'cd' here is a bad practice. I
> just don't think it's about skipping setup --- instead, it's about it
> being hard to remember the cwd in general.
Exactly.
next prev parent reply other threads:[~2014-02-06 21:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 12:48 attr.c doesn't honor --work-tree option Lasse Makholm
2014-02-06 17:54 ` Junio C Hamano
2014-02-06 18:40 ` [PATCH 1/2] t0003: do not chdir the whole test process Junio C Hamano
2014-02-06 18:40 ` [PATCH 2/2] check-attr: move to the top of working tree when in non-bare repository Junio C Hamano
2014-02-06 19:53 ` Jonathan Nieder
2014-02-06 20:17 ` Jonathan Nieder
2014-02-06 20:32 ` Junio C Hamano
2014-02-16 11:15 ` Michael Haggerty
2014-02-06 19:45 ` [PATCH 1/2] t0003: do not chdir the whole test process Jonathan Nieder
2014-02-06 20:25 ` Junio C Hamano
2014-02-06 20:31 ` Jonathan Nieder
2014-02-06 21:26 ` Junio C Hamano [this message]
2014-02-10 12:57 ` attr.c doesn't honor --work-tree option Lasse Makholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2j0x78w.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=lasse.makholm@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox