From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org, Lasse Makholm <lasse.makholm@gmail•com>
Subject: Re: [PATCH 2/2] check-attr: move to the top of working tree when in non-bare repository
Date: Thu, 06 Feb 2014 12:32:31 -0800 [thread overview]
Message-ID: <xmqqr47gx9r4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140206201743.GW30398@google.com> (Jonathan Nieder's message of "Thu, 6 Feb 2014 12:17:43 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Someone asked in a private reply how this interacts with t0003.
It was me mistakenly using "reply" not "reply all".
> t0003 tries check-attr in a bare repository. The question is, is that
> a desirable feature, and are people relying on it?
Running tar-tree from a public distribution point comes to mind.
bootstrap-attr-stack seems to have reference to is-bare-repository
to validate the attribute direction to read from the index, but I
tend to think what it really wants is to read from HEAD not the
index.
> How do I use the only-look-at-HEAD mode from a non-bare repo?
Is "You don't" a good answer?
Use of --cached when your index matches HEAD is the equivalent, and
if the index differs from HEAD, you must have had a reason to add
that change to .gitattributes to the index, so I think it is
reasonable to honour that change.
next prev parent reply other threads:[~2014-02-06 20:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 12:48 attr.c doesn't honor --work-tree option Lasse Makholm
2014-02-06 17:54 ` Junio C Hamano
2014-02-06 18:40 ` [PATCH 1/2] t0003: do not chdir the whole test process Junio C Hamano
2014-02-06 18:40 ` [PATCH 2/2] check-attr: move to the top of working tree when in non-bare repository Junio C Hamano
2014-02-06 19:53 ` Jonathan Nieder
2014-02-06 20:17 ` Jonathan Nieder
2014-02-06 20:32 ` Junio C Hamano [this message]
2014-02-16 11:15 ` Michael Haggerty
2014-02-06 19:45 ` [PATCH 1/2] t0003: do not chdir the whole test process Jonathan Nieder
2014-02-06 20:25 ` Junio C Hamano
2014-02-06 20:31 ` Jonathan Nieder
2014-02-06 21:26 ` Junio C Hamano
2014-02-10 12:57 ` attr.c doesn't honor --work-tree option Lasse Makholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr47gx9r4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=lasse.makholm@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox