From: Junio C Hamano <gitster@pobox•com>
To: Tomas Nordin <tomasn@posteo•net>
Cc: git@vger•kernel.org, Charvi Mendiratta <charvi077@gmail•com>
Subject: Re: Unbalanced closing paren in help of git commit
Date: Mon, 22 Jul 2024 11:58:54 -0700 [thread overview]
Message-ID: <xmqqed7lb6dt.fsf@gitster.g> (raw)
In-Reply-To: <871q3nx7f3.fsf@posteo.net> (Tomas Nordin's message of "Sun, 21 Jul 2024 12:21:04 +0000")
Tomas Nordin <tomasn@posteo•net> writes:
> So then I make an attempt to provide a patch to remove that closing
> parenthesis. Please tell if it should be done differently somehow. The
> patch was done on top of maint.
>
> From 5da052f43b119949c0ac0c7c3047542bc7474c17 Mon Sep 17 00:00:00 2001
> From: Tomas Nordin <tomasn@posteo•net>
> Date: Sun, 21 Jul 2024 13:16:50 +0200
> Subject: [PATCH] doc: remove dangling closing parenthesis
We do not "attach" patches to an e-mail, like this. Please visit
https://lore.kernel.org/git/ and check patch messages from others.
An example:
https://lore.kernel.org/git/e048ef54-5824-452d-ab1f-233581711f4e@web.de/
Your Subject: looks good. It shows that the author read (at least
some parts of) Documentation/SubmittingPatches.
> * Documentation/git-commit.txt:
> The second line of the synopsis, starting with [--dry-run] has a
> dangling closing paren in the second optional group. Probably added by
> misstake, so remove it.
We do not work file-by-file. If any reader wants to know which
paths were affected, they can see the diffstat before the patch.
I think what you wrote is just fine otherwise; just drop the "*
Documentation/git-commit" line, dedent the body of the paragraph,
and typofix the "misstake".
Thanks.
> Signed-off-by: Tomas Nordin <tomasn@posteo•net>
> ---
> Documentation/git-commit.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
> index 89ecfc63a8..c822113c11 100644
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -9,7 +9,7 @@ SYNOPSIS
> --------
> [verse]
> 'git commit' [-a | --interactive | --patch] [-s] [-v] [-u<mode>] [--amend]
> - [--dry-run] [(-c | -C | --squash) <commit> | --fixup [(amend|reword):]<commit>)]
> + [--dry-run] [(-c | -C | --squash) <commit> | --fixup [(amend|reword):]<commit>]
> [-F <file> | -m <msg>] [--reset-author] [--allow-empty]
> [--allow-empty-message] [--no-verify] [-e] [--author=<author>]
> [--date=<date>] [--cleanup=<mode>] [--[no-]status]
next prev parent reply other threads:[~2024-07-22 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 12:33 Unbalanced closing paren in help of git commit Tomas Nordin
2024-07-08 8:54 ` Jeff King
2024-07-08 19:35 ` Tomas Nordin
2024-07-08 23:35 ` Jeff King
2024-07-08 19:57 ` Junio C Hamano
2024-07-21 12:21 ` Tomas Nordin
2024-07-22 18:58 ` Junio C Hamano [this message]
2024-07-22 22:59 ` Tomas Nordin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqed7lb6dt.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=charvi077@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tomasn@posteo$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox