public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Tomas Nordin <tomasn@posteo•net>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: Unbalanced closing paren in help of git commit
Date: Mon, 08 Jul 2024 19:35:03 +0000	[thread overview]
Message-ID: <87le2b3cew.fsf@posteo.net> (raw)
In-Reply-To: <20240708085440.GA819809@coredump.intra.peff.net>

Jeff King <peff@peff•net> writes:

> On Sun, Jul 07, 2024 at 12:33:21PM +0000, Tomas Nordin wrote:
>
>> The second line of the help message for git commit looks like this:
>> 
>>     [--dry-run] [(-c | -C | --squash) <commit> | --fixup [(amend|reword):]<commit>)]
>> 
>> See for example https://gitirc.eu/git-commit.html. It has two opening
>> parens and three closing parens. <commit> ends with a closing paren
>> before the closing bracket. Me and gsish (on IRC) suspect this is a
>> misstake.
>> 
>> What do you think?
>
> Yep, looks like a typo introduced by 00ea64ed7a (doc/git-commit: add
> documentation for fixup=[amend|reword] options, 2021-03-15).

I stumbled upon it while working on a synopsis parsing tool, similar to
the Python docopt if familiar.

> Want to try your hand at producing a patch? (It's OK if the answer is
> no; it just seems like a good opportunity for somebody to get their feet
> wet on contributing).

I can try, why not? Should I hang it up on this thread so to say. Is
this a bug report?

  reply	other threads:[~2024-07-08 19:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-07 12:33 Unbalanced closing paren in help of git commit Tomas Nordin
2024-07-08  8:54 ` Jeff King
2024-07-08 19:35   ` Tomas Nordin [this message]
2024-07-08 23:35     ` Jeff King
2024-07-08 19:57 ` Junio C Hamano
2024-07-21 12:21   ` Tomas Nordin
2024-07-22 18:58     ` Junio C Hamano
2024-07-22 22:59       ` Tomas Nordin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le2b3cew.fsf@posteo.net \
    --to=tomasn@posteo$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox