From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org
Subject: Re: [RFH] renaming strcmp/strncmp-icase
Date: Mon, 08 Sep 2014 12:56:01 -0700 [thread overview]
Message-ID: <xmqqegvlnay6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <540E03F6.3010100@web.de> ("Torsten Bögershausen"'s message of "Mon, 08 Sep 2014 21:31:02 +0200")
Torsten Bögershausen <tboegi@web•de> writes:
> And then we have this in name-hash.c:
> (Which may explain the "icase" suffix ?)
>
> static int same_name(const struct cache_entry *ce, const char *name, int namelen, int icase)
As this file-scope static function takes the "icase" as an explicit
argument, I do not see anything confusing about it. My complaint
was it is confusing that str[n]cmp_icase is not always icase, even
though the name of the function implies that it would be to those
who haven't looked at its implementation for a while.
next prev parent reply other threads:[~2014-09-08 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 18:52 [RFH] renaming strcmp/strncmp-icase Junio C Hamano
2014-09-08 19:31 ` Torsten Bögershausen
2014-09-08 19:56 ` Junio C Hamano [this message]
2014-09-08 21:36 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegvlnay6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox