public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: Git in GSoC 2014
Date: Thu, 27 Feb 2014 12:32:34 -0800	[thread overview]
Message-ID: <xmqqfvn4xpnh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <530F9F59.4030307@alum.mit.edu> (Michael Haggerty's message of "Thu, 27 Feb 2014 21:26:01 +0100")

Michael Haggerty <mhagger@alum•mit.edu> writes:

> On 02/27/2014 08:19 PM, Junio C Hamano wrote:
>> Michael Haggerty <mhagger@alum•mit.edu> writes:
>> 
>>> Sounds good.  I suggest we make your blob a paragraph before the list of
>>> bullet points rather than part of the list.  Please suggest some "TBD*"
>>> then I'll add it to the text.  Would we also fill in "X" with the name
>>> of the actual student involved in the conversation that is pointed to?
>> 
>> I was not thinking about using a student thread (I do not remember
>> having a good on-list interaction with past GSoC students).
>> 
>> How about using this one from our recent past:
>> 
>>     http://thread.gmane.org/gmane.comp.version-control.git/239068
>> 
>> which has the following good points to be used as an example.  It:
>> 
>>  - involved multiple cycles and multiple reviewers;
>> 
>>  - showed good response to the comments from the original author;
>>    and most importantly
>> 
>>  - had everything related to the topic in one single neat thread.
>> 
>
> Change pushed.  Thanks Junio!

Thank you for starting this.

Another point to add to the above three-point list is that it had an
example of the original author defending (some of) the design
choices he made and reviewers who initially raised questions and/or
issues agreeing with that choice after the thinking was clearly
explained.

  reply	other threads:[~2014-02-27 20:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 15:41 Git in GSoC 2014 Jeff King
2014-02-25 16:42 ` Dmitry S. Dolzhenko
2014-02-25 17:15 ` Michael Haggerty
2014-02-26 10:23   ` Jeff King
2014-02-26 10:41     ` Michael Haggerty
2014-02-26 11:04       ` Jeff King
2014-02-26 11:25       ` Vicent Martí
2014-02-26 11:29         ` Jeff King
2014-02-26 19:48       ` Junio C Hamano
2014-02-27  7:34         ` Michael Haggerty
2014-02-27 19:19           ` Junio C Hamano
2014-02-27 20:26             ` Michael Haggerty
2014-02-27 20:32               ` Junio C Hamano [this message]
2014-04-22  1:06                 ` Andrew Ardill
2014-04-22  2:18                   ` Brian Gesiak
2014-02-26 11:16 ` Duy Nguyen
2014-02-26 11:24   ` Vicent Martí
2014-02-26 11:30     ` Jeff King
2014-02-26 16:48       ` Shawn Pearce
2014-02-26 17:15 ` Git in GSoC 2014 Suggestion: core.filemode always false for cygwin Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfvn4xpnh.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox