From: Junio C Hamano <gitster@pobox•com>
To: "Aryan Gupta via GitGitGadget" <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, "Patrick Steinhardt" <ps@pks•im>,
"Michal Suchánek" <msuchanek@suse•de>,
"Jean-Noël AVILA" <jn.avila@free•fr>,
"Kristoffer Haugsbakk" <code@khaugsbakk•name>,
"Eric Sunshine" <sunshine@sunshineco•com>,
"Aryan Gupta" <garyan447@gmail•com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx•de>
Subject: Re: [PATCH v3] tests: modernize the test script t0010-racy-git.sh
Date: Tue, 05 Mar 2024 15:02:45 -0800 [thread overview]
Message-ID: <xmqqh6hkxox6.fsf@gitster.g> (raw)
In-Reply-To: <pull.1675.v3.git.1709676557639.gitgitgadget@gmail.com> (Aryan Gupta via GitGitGadget's message of "Tue, 05 Mar 2024 22:09:17 +0000")
"Aryan Gupta via GitGitGadget" <gitgitgadget@gmail•com> writes:
> From: Aryan Gupta <garyan447@gmail•com>
>
> Modernize the formatting of the test script to align with current
> standards and improve its overall readability.
>
> Signed-off-by: Aryan Gupta <garyan447@gmail•com>
> ---
Both the above proposed commit log message and the proposed changes
to the code look good.
This is a tangent but as can be seen at
https://lore.kernel.org/git/pull.1675.v3.git.1709676557639.gitgitgadget@gmail.com/raw
your message has these headers that are not syntactically correct
and may even cause responses to bounce unless editted.
Cc: "Patrick Steinhardt [ ]" <ps@pks•im>,
"Michal =?UTF-8?Q?Such=C3=A1nek?= [ ]" <msuchanek@suse•de>,
"=?UTF-8?Q?Jean-No=C3=ABl?= AVILA [ ]" <jn.avila@free•fr>,
Kristoffer Haugsbakk <[code@khaugsbakk•name]>,
Eric Sunshine <sunshine@sunshineco•com>,
Aryan Gupta <garyan447@gmail•com>,
Aryan Gupta <garyan447@gmail•com>
I cannot tell if this is a bug in GGG, or a fault of a corrupt pull
request thrown at GGG, but it is annoying that recipients have to
edit the addresses in e-mail header. Can somebody take a look into
it, please (or is it a known issue?).
Thanks.
next prev parent reply other threads:[~2024-03-05 23:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 12:23 [PATCH] tests: modernize the test script t0010-racy-git.sh Aryan Gupta via GitGitGadget
2024-02-29 18:11 ` Eric Sunshine
2024-02-29 21:57 ` [PATCH v2] " Aryan Gupta via GitGitGadget
2024-02-29 22:19 ` Eric Sunshine
2024-02-29 23:14 ` Junio C Hamano
2024-02-29 23:22 ` Eric Sunshine
2024-02-29 23:36 ` Junio C Hamano
2024-02-29 23:52 ` Eric Sunshine
2024-03-01 0:06 ` Eric Sunshine
2024-03-01 2:03 ` Junio C Hamano
2024-03-05 22:09 ` [PATCH v3] " Aryan Gupta via GitGitGadget
2024-03-05 23:02 ` Junio C Hamano [this message]
2024-03-06 9:14 ` [PATCH v4] " Aryan Gupta via GitGitGadget
2024-03-07 13:28 ` Christian Couder
2024-03-07 14:23 ` Aryan Gupta
2024-03-07 18:17 ` Junio C Hamano
2024-03-07 18:30 ` Junio C Hamano
2024-03-07 18:33 ` Aryan Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6hkxox6.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=code@khaugsbakk$(echo .)name \
--cc=garyan447@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=jn.avila@free$(echo .)fr \
--cc=msuchanek@suse$(echo .)de \
--cc=ps@pks$(echo .)im \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox