public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
	"git@vger•kernel.org" <git@vger•kernel.org>
Subject: Re: [PATCH] strbuf: stop out-of-boundary warnings from Coverity
Date: Wed, 17 Jun 2015 12:25:58 -0700	[thread overview]
Message-ID: <xmqqh9q66ss9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGZ79kbZpiz2rMbhJReFG=uRiQdj7a5qxLbRiPQQCFqcfBhikw@mail.gmail.com> (Stefan Beller's message of "Wed, 17 Jun 2015 10:58:10 -0700")

Stefan Beller <sbeller@google•com> writes:

>> Just make strbuf_slopbuf[] large enough to keep Coverity happy. If it's
>> happy, we'll have cleaner defect list
>
> It's down 31 defects, roughly 10% of all things coverity detected as
> problematic.
> YAY!

I actually think this is too ugly to live.  If coverity is buggy and
unusable, why aren't we raising that issue to them?

  parent reply	other threads:[~2015-06-17 19:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 10:16 [PATCH] strbuf: stop out-of-boundary warnings from Coverity Nguyễn Thái Ngọc Duy
2015-06-17 17:28 ` Stefan Beller
2015-06-17 17:58   ` Stefan Beller
2015-06-17 19:12     ` Jeff King
2015-06-17 20:03       ` Stefan Beller
2015-06-18 10:13       ` Duy Nguyen
2015-06-18 16:46         ` Junio C Hamano
2015-06-19 10:39           ` Duy Nguyen
2015-06-19 10:50             ` Remi Galan Alfonso
2015-06-19 10:51               ` Duy Nguyen
2015-06-19 15:27             ` Junio C Hamano
2015-06-17 19:25     ` Junio C Hamano [this message]
2015-06-17 20:05       ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh9q66ss9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pclouds@gmail$(echo .)com \
    --cc=sbeller@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox