public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org, Antoine Pelisse <apelisse@gmail•com>
Subject: Re: What's cooking in git.git (Mar 2014, #03; Fri, 14)
Date: Mon, 17 Mar 2014 10:01:34 -0700	[thread overview]
Message-ID: <xmqqha6wg3o1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53240C0F.2050204@web.de> ("Torsten Bögershausen"'s message of "Sat, 15 Mar 2014 09:15:11 +0100")

Torsten Bögershausen <tboegi@web•de> writes:

> On 2014-03-14 23.09, Junio C Hamano wrote:
>> * ap/remote-hg-skip-null-bookmarks (2014-01-02) 1 commit
>>  - remote-hg: do not fail on invalid bookmarks
>> 
>>  Reported to break tests ($gmane/240005)
>>  Expecting a reroll.
> I wonder what should happen here.
> The change breaks all the tests in test-hg-hg-git.sh
> (And the breakage may prevent us from detecting other breakages)
>
> The ideal situation would be to have an extra test case for the problem
> which we try to fix with this patch.
>
> Antoine, is there any way to make your problem reproducable ?
> And based on that, to make a patch which passes all test cases ?

After re-reading the thread briefly (there're just five messages)

  http://thread.gmane.org/gmane.comp.version-control.git/239797/focus=240069

I think the "breakage" the patch tries to fix seems to be of dubious
nature in the first place ("I don't know how I ended-up with such a
bookmark", Antoine says in $gmane/239800), and it has been in
"Expecting a reroll" state in response to "I will try to come-up
with an improved version" in $gmane/240069 but nothing has happened
for a few months.

At this point I think it would be OK for me to discard the topic
(without prejudice); if the root cause of the issue (if there is
one) and a proper fix is discovered in the future, the topic can
come back with a fresh patch, but it appears to me that keeping the
above patch in my tree would not help anybody.

Thanks.

next prev parent reply	other threads:[~2014-03-17 17:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 22:09 What's cooking in git.git (Mar 2014, #03; Fri, 14) Junio C Hamano
2014-03-15  8:15 ` Torsten Bögershausen
2014-03-17 17:01   ` Junio C Hamano [this message]
2014-03-19 10:53     ` Max Horn
2014-03-19 12:32       ` Max Horn
2014-03-19 17:04       ` Junio C Hamano
2014-03-19 17:21         ` Max Horn
2014-03-19 18:53           ` Junio C Hamano
2014-03-15 12:34 ` Duy Nguyen
2014-03-17 18:05   ` Junio C Hamano
2014-03-16 18:30 ` Philip Oakley
2014-03-16 23:15   ` Ramkumar Ramachandra
2014-03-17 18:01     ` Junio C Hamano
2014-03-17 22:41     ` Philip Oakley
2014-03-17 17:21   ` Junio C Hamano
2014-03-18  0:16     ` Philip Oakley
2014-03-18  4:40   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqha6wg3o1.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=apelisse@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tboegi@web$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox