From: Junio C Hamano <gitster@pobox•com>
To: Max Horn <max@quendi•de>
Cc: "Torsten Bögershausen" <tboegi@web•de>,
git@vger•kernel.org, "Antoine Pelisse" <apelisse@gmail•com>
Subject: Re: What's cooking in git.git (Mar 2014, #03; Fri, 14)
Date: Wed, 19 Mar 2014 10:04:37 -0700 [thread overview]
Message-ID: <xmqqlhw65dcq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <906CACC0-FB16-4BB8-812D-59067DE0CC89@quendi.de> (Max Horn's message of "Wed, 19 Mar 2014 11:53:57 +0100")
Max Horn <max@quendi•de> writes:
> On 17.03.2014, at 18:01, Junio C Hamano <gitster@pobox•com> wrote:
>
>> Torsten Bögershausen <tboegi@web•de> writes:
>>
>>> On 2014-03-14 23.09, Junio C Hamano wrote:
>>>> * ap/remote-hg-skip-null-bookmarks (2014-01-02) 1 commit
>>>> - remote-hg: do not fail on invalid bookmarks
>>>>
>>>> Reported to break tests ($gmane/240005)
>>>> Expecting a reroll.
>>> I wonder what should happen here.
>>> The change breaks all the tests in test-hg-hg-git.sh
>>> (And the breakage may prevent us from detecting other breakages)
>>>
>>> The ideal situation would be to have an extra test case for the problem
>>> which we try to fix with this patch.
>>>
>>> Antoine, is there any way to make your problem reproducable ?
>>> And based on that, to make a patch which passes all test cases ?
>>
>> After re-reading the thread briefly (there're just five messages)
>>
>> http://thread.gmane.org/gmane.comp.version-control.git/239797/focus=240069
>
> For some reason, that link does not contain all messages from that
> conversation (unfortunately, I have seen GMane do that on multiple
> occasions. I hence try not to rely on it for reviewing email
> history -- I just don't trust it). In particular, it misses this
> crucial post:
[jc: please avoid overlong lines; I re-flowed above]
> http://thread.gmane.org/gmane.comp.version-control.git/239830
Interesting.
> The (or at least "a") root cause has actually been
> discovered. Would a patch that adds an xfail test case for it be
> acceptable?
Do you mean a patch that only adds a new test that expects a failure
to the current code, without touching the current code that has the
bug it exposes? That would be a good place to start.
> ... As a matter of fact, I a know a few more bugs in remote-hg for
> which I could produce xfail test cases. Of course I'd prefer to
> put them in together with a fix, but I don't know when I can get
> to that, if ever. So, would such changes be welcome?
Surely. That is to keep tabs on bugs in an actionable form; it is a
better way of bug tracking than having a bug-tracker that is not
actively maintained, I would think.
next prev parent reply other threads:[~2014-03-19 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 22:09 What's cooking in git.git (Mar 2014, #03; Fri, 14) Junio C Hamano
2014-03-15 8:15 ` Torsten Bögershausen
2014-03-17 17:01 ` Junio C Hamano
2014-03-19 10:53 ` Max Horn
2014-03-19 12:32 ` Max Horn
2014-03-19 17:04 ` Junio C Hamano [this message]
2014-03-19 17:21 ` Max Horn
2014-03-19 18:53 ` Junio C Hamano
2014-03-15 12:34 ` Duy Nguyen
2014-03-17 18:05 ` Junio C Hamano
2014-03-16 18:30 ` Philip Oakley
2014-03-16 23:15 ` Ramkumar Ramachandra
2014-03-17 18:01 ` Junio C Hamano
2014-03-17 22:41 ` Philip Oakley
2014-03-17 17:21 ` Junio C Hamano
2014-03-18 0:16 ` Philip Oakley
2014-03-18 4:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhw65dcq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=apelisse@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=max@quendi$(echo .)de \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox