From: Junio C Hamano <gitster@pobox•com>
To: Elijah Newren <newren@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>,
Karthik Nayak <karthik.188@gmail•com>,
Jeff King <peff@peff•net>, Patrick Steinhardt <ps@pks•im>
Subject: Re: Possible regression: lost diagnostic message when pushing non-commit objects to refs/heads/*
Date: Wed, 24 Dec 2025 12:37:26 +0900 [thread overview]
Message-ID: <xmqqikdwo8i1.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGL2tJR4dPidQuFcp-X0_VkVTknCY-0Zgo=jHVGv_P=wA@mail.gmail.com> (Elijah Newren's message of "Tue, 23 Dec 2025 19:32:28 -0800")
Elijah Newren <newren@gmail•com> writes:
> Bisecting shows that this
> started with commit 9d2962a7c44 ("receive-pack: use batched reference
> updates", 2025-05-19). That commit message to me suggests that while
> error handling was necessarily changed, that dropping the errors was
> not intentional:
>
> ```
> As using batched updates requires the error handling to be moved to the
> end of the flow, create and use a 'struct strset' to track the failed
> refs and attribute the correct errors to them.
> ```
>
> But it's possible I'm reading it wrong. Was it intentional, or is
> this a regression?
The topic bisect found was supposed to be purely performance
optimization, and we should take any changes in behaviour as
regressions.
Thanks.
next prev parent reply other threads:[~2025-12-24 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 3:32 Possible regression: lost diagnostic message when pushing non-commit objects to refs/heads/* Elijah Newren
2025-12-24 3:37 ` Junio C Hamano [this message]
2025-12-24 8:12 ` Jeff King
2025-12-24 8:21 ` Jeff King
2025-12-26 16:48 ` Karthik Nayak
2025-12-27 7:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqikdwo8i1.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox