From: Junio C Hamano <gitster@pobox•com>
To: Shuqi Liang <cheskaqiqi@gmail•com>
Cc: git@vger•kernel.org, vdye@github•com, derrickstolee@github•com
Subject: Re: [RFC][PATCH v1] write-tree: integrate with sparse index
Date: Mon, 03 Apr 2023 13:58:15 -0700 [thread overview]
Message-ID: <xmqqilec4ra0.fsf@gitster.g> (raw)
In-Reply-To: <20230402000117.313171-1-cheskaqiqi@gmail.com> (Shuqi Liang's message of "Sat, 1 Apr 2023 20:01:17 -0400")
Shuqi Liang <cheskaqiqi@gmail•com> writes:
> Update 'git write-tree' to allow using the sparse-index in memory
> without expanding to a full one.
>
> The recursive algorithm for update_one() was already updated in 2de37c5
> (cache-tree: integrate with sparse directory entries, 2021-03-03) to
> handle sparse directory entries in the index. Hence we can just set the
> requires-full-index to false for "write-tree".
>
> The `p2000` tests demonstrate a ~96% execution time reduction for 'git
> write-tree' using a sparse index:
>
> Test before after
> -----------------------------------------------------------------
> 2000.78: git write-tree (full-v3) 0.34 0.33 -2.9%
> 2000.79: git write-tree (full-v4) 0.32 0.30 -6.3%
> 2000.80: git write-tree (sparse-v3) 0.47 0.02 -95.8%
> 2000.81: git write-tree (sparse-v4) 0.45 0.02 -95.6%
>
> Signed-off-by: Shuqi Liang <cheskaqiqi@gmail•com>
> ---
> builtin/write-tree.c | 4 ++++
> t/perf/p2000-sparse-operations.sh | 1 +
> t/t1092-sparse-checkout-compatibility.sh | 28 ++++++++++++++++++++++++
> 3 files changed, 33 insertions(+)
Has the test suite been exercised with this patch? It seems to
break at least t0012
next prev parent reply other threads:[~2023-04-03 20:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 0:01 [RFC][PATCH v1] write-tree: integrate with sparse index Shuqi Liang
2023-04-03 20:58 ` Junio C Hamano [this message]
2023-04-03 22:16 ` Shuqi Liang
2023-04-03 22:54 ` Junio C Hamano
2023-04-04 0:35 ` [PATCH v2] " Shuqi Liang
2023-04-05 17:31 ` Victoria Dye
2023-04-05 19:48 ` Junio C Hamano
2023-04-19 7:21 ` [PATCH v3] " Shuqi Liang
2023-04-19 15:47 ` Junio C Hamano
2023-04-20 5:24 ` Shuqi Liang
2023-04-20 15:55 ` Junio C Hamano
2023-04-21 0:41 ` [PATCH v4] " Shuqi Liang
2023-04-21 21:42 ` Victoria Dye
2023-04-24 15:14 ` Junio C Hamano
2023-04-23 7:12 ` [PATCH v5] write-tree: optimize sparse integration Shuqi Liang
2023-04-24 16:00 ` Junio C Hamano
2023-05-08 20:05 ` [PATCH v6] " Shuqi Liang
2023-05-08 20:21 ` Shuqi Liang
2023-05-08 21:09 ` Junio C Hamano
2023-05-08 21:27 ` Shuqi Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilec4ra0.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=cheskaqiqi@gmail$(echo .)com \
--cc=derrickstolee@github$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=vdye@github$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox