From: Junio C Hamano <gitster@pobox•com>
To: Shuqi Liang <cheskaqiqi@gmail•com>
Cc: git@vger•kernel.org, vdye@github•com, derrickstolee@github•com
Subject: Re: [PATCH v6] write-tree: optimize sparse integration
Date: Mon, 08 May 2023 14:09:50 -0700 [thread overview]
Message-ID: <xmqqednqmswx.fsf@gitster.g> (raw)
In-Reply-To: <20230508202140.464363-1-cheskaqiqi@gmail.com> (Shuqi Liang's message of "Mon, 8 May 2023 16:21:40 -0400")
Shuqi Liang <cheskaqiqi@gmail•com> writes:
> * 'on all' in the title of the test 'write-tree on all' was unclear;
> remove it.
>
> * Add a baseline 'test_all_match git write-tree' before making any
> changes to the index, providing a reference point for the 'write-tree'
> prior to any modifications.
>
> * Add a comparison of the output of 'git status --porcelain=v2' to test
> the working tree after 'write-tree' exits.
>
> * Ensure SKIP_WORKTREE files weren't materialized on disk by using
> "test_path_is_missing".
>
> Signed-off-by: Shuqi Liang <cheskaqiqi@gmail•com>
> ---
>
As we have lost the change to the code, the title has become stale.
How about I retitle it like so after queuing the patch?
Subject: t1092: update write-tree test
The changes to the test seem to match what Victoria already gave a
thums-up in her review of v4; I see nothing surprising or unexpected
there.
Thanks. Will queue.
next prev parent reply other threads:[~2023-05-08 21:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 0:01 [RFC][PATCH v1] write-tree: integrate with sparse index Shuqi Liang
2023-04-03 20:58 ` Junio C Hamano
2023-04-03 22:16 ` Shuqi Liang
2023-04-03 22:54 ` Junio C Hamano
2023-04-04 0:35 ` [PATCH v2] " Shuqi Liang
2023-04-05 17:31 ` Victoria Dye
2023-04-05 19:48 ` Junio C Hamano
2023-04-19 7:21 ` [PATCH v3] " Shuqi Liang
2023-04-19 15:47 ` Junio C Hamano
2023-04-20 5:24 ` Shuqi Liang
2023-04-20 15:55 ` Junio C Hamano
2023-04-21 0:41 ` [PATCH v4] " Shuqi Liang
2023-04-21 21:42 ` Victoria Dye
2023-04-24 15:14 ` Junio C Hamano
2023-04-23 7:12 ` [PATCH v5] write-tree: optimize sparse integration Shuqi Liang
2023-04-24 16:00 ` Junio C Hamano
2023-05-08 20:05 ` [PATCH v6] " Shuqi Liang
2023-05-08 20:21 ` Shuqi Liang
2023-05-08 21:09 ` Junio C Hamano [this message]
2023-05-08 21:27 ` Shuqi Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqednqmswx.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=cheskaqiqi@gmail$(echo .)com \
--cc=derrickstolee@github$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=vdye@github$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox