From: Junio C Hamano <gitster@pobox•com>
To: John Keeping <john@keeping•me.uk>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCH v2 0/6] Make "local" orthogonal to date format
Date: Wed, 02 Sep 2015 13:11:35 -0700 [thread overview]
Message-ID: <xmqqk2s8mvig.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20150902194946.GL30659@serenity.lan> (John Keeping's message of "Wed, 2 Sep 2015 20:49:46 +0100")
John Keeping <john@keeping•me.uk> writes:
> On Wed, Sep 02, 2015 at 08:16:59AM -0700, Junio C Hamano wrote:
>> Jeff King <peff@peff•net> writes:
>>
>> > I guess "relative dates do not depend on timezones, so -local is
>> > meaningless" would be the closest thing.
>
> The discussion about "raw-local" was in a separate subthread, I think
> we're just bikeshedding the particular error message here.
OK.
> OTOH, I don't think there's any disagreement about what "relative-local"
> and "raw-local" would output were they supported, just whether they are
> useful. There doesn't seem to be any harm in supporting them;
> "relative-local" will be identical to "relative" and "raw-local" will
> require preparatory code movement for the raw output.
Sure.
Bikeshedding further, while Peff's message "-local is meaningless"
is a correct statement of the fact, I do not think it explains well
why we chose to error out instead of giving the most natural result
(i.e. exactly the same as 'relative').
Perhaps stating "relative-local is not supported" without saying why
would be better. "Because it is meaningless, we refuse to support
the option." is a very strong statement that tells aspiring future
Git hackers not to attempt to add a support for it, which is
probably a wrong message to send.
next prev parent reply other threads:[~2015-09-02 20:11 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 13:54 [RFC/PATCH] date: allow any format to display local time John Keeping
2015-08-31 17:28 ` Junio C Hamano
2015-08-31 18:50 ` Jeff King
2015-08-31 18:56 ` Jeff King
2015-08-31 19:57 ` Junio C Hamano
2015-08-31 20:00 ` John Keeping
2015-08-31 20:44 ` Jeff King
2015-08-31 20:47 ` [PATCH 1/2] fast-import: switch crash-report date to iso8601 Jeff King
2015-08-31 20:48 ` [PATCH 2/2] date: make "local" orthogonal to date format Jeff King
2015-08-31 21:27 ` John Keeping
2015-08-31 21:33 ` Jeff King
2015-08-31 22:05 ` Jeff King
2015-09-01 8:37 ` John Keeping
2015-09-01 21:55 ` [PATCH v2 0/6] Make " John Keeping
2015-09-01 21:55 ` [PATCH v2 1/6] fast-import: switch crash-report date to iso8601 John Keeping
2015-09-01 21:55 ` [PATCH v2 2/6] date: make "local" orthogonal to date format John Keeping
2015-09-01 22:16 ` Junio C Hamano
2015-09-01 22:25 ` Jeff King
2015-09-01 22:33 ` John Keeping
2015-09-01 22:39 ` Jeff King
2015-09-01 22:41 ` Junio C Hamano
2015-09-02 17:36 ` Junio C Hamano
2015-09-01 21:55 ` [PATCH v2 3/6] t6300: introduce test_date() helper John Keeping
2015-09-01 22:19 ` Junio C Hamano
2015-09-01 22:26 ` Eric Sunshine
2015-09-01 22:31 ` Jeff King
2015-09-01 22:40 ` John Keeping
2015-09-01 22:41 ` Jeff King
2015-09-01 21:55 ` [PATCH v2 4/6] t6300: make UTC and local dates different John Keeping
2015-09-01 21:55 ` [PATCH v2 5/6] t6300: add test for "raw" date format John Keeping
2015-09-01 21:55 ` [PATCH v2 6/6] t6300: add tests for "-local" date formats John Keeping
2015-09-01 22:44 ` [PATCH v2 0/6] Make "local" orthogonal to date format Jeff King
2015-09-02 7:48 ` John Keeping
2015-09-02 8:05 ` Jeff King
2015-09-02 15:16 ` Junio C Hamano
2015-09-02 19:49 ` John Keeping
2015-09-02 20:11 ` Junio C Hamano [this message]
2015-09-02 20:21 ` John Keeping
2015-09-02 20:29 ` Junio C Hamano
2015-09-02 21:27 ` Jeff King
2015-09-03 21:48 ` [PATCH v3 00/11] " John Keeping
2015-09-03 21:48 ` [PATCH v3 01/11] Documentation/blame-options: don't list date formats John Keeping
2015-09-03 21:48 ` [PATCH v3 02/11] Documentation/config: " John Keeping
2015-09-03 21:48 ` [PATCH v3 03/11] Documentation/git-for-each-ref: " John Keeping
2015-09-03 21:48 ` [PATCH v3 04/11] Documentation/rev-list: " John Keeping
2015-09-03 22:36 ` Junio C Hamano
2015-09-03 21:48 ` [PATCH v3 05/11] fast-import: switch crash-report date to iso8601 John Keeping
2015-09-03 21:48 ` [PATCH v3 06/11] t6300: introduce test_date() helper John Keeping
2015-09-03 21:48 ` [PATCH v3 07/11] t6300: add test for "raw" date format John Keeping
2015-09-03 21:48 ` [PATCH v3 08/11] date: check for "local" before anything else John Keeping
2015-09-03 22:45 ` Junio C Hamano
2015-09-03 21:48 ` [PATCH v3 09/11] date: make "local" orthogonal to date format John Keeping
2015-09-03 21:49 ` [PATCH v3 10/11] t6300: make UTC and local dates different John Keeping
2015-09-03 21:49 ` [PATCH v3 11/11] t6300: add tests for "-local" date formats John Keeping
2015-09-08 7:53 ` [PATCH v3 00/11] Make "local" orthogonal to date format Jeff King
2015-09-02 17:41 ` [PATCH 2/2] date: make " Junio C Hamano
2015-09-02 21:30 ` Jeff King
2015-09-02 22:07 ` John Keeping
2015-09-03 15:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2s8mvig.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox