public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Joey Hess <id@joeyh•name>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
	Git Mailing List <git@vger•kernel.org>,
	Paul Tan <pyokagan@gmail•com>
Subject: Re: git pull --upload-pack reversion in git 2.5.0
Date: Fri, 31 Jul 2015 10:54:16 -0700	[thread overview]
Message-ID: <xmqqk2tg5i2f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPc5daXPY7RQSM6oyFYJ2LjYjaT9dDG-+3=nbHONirGh50pdBA@mail.gmail.com> (Junio C. Hamano's message of "Thu, 30 Jul 2015 11:41:31 -0700")

Junio C Hamano <gitster@pobox•com> writes:

> On Thu, Jul 30, 2015 at 11:31 AM, Joey Hess <id@joeyh•name> wrote:
>> I think this comes down to a lack of quoting where git-pull runs
>> git-fetch. Before eb2a8d9ed3fca2ba2f617b704992d483605f3bb6,
>> "$@" was passed through to git-fetch, but now there is a $upload_pack
>> which is passed without being quoted.
>
> Yes, it is not just the matter of using "$upload_pack", though ;-)
>
> ${upload_pack+"$upload_pack"} or something.

Thanks for a bug report.

The next time, I'd appreciate if these regressions are caught before
it hits the tagged release, during the pre-release -rc period at the
latest, but preferrably earlier.  I'm greedy and expect far more
from those who are known to be competent heavy Git users than from
"I update every few releases" casual folks ;-)

Thanks, anyway.

     prev parent reply	other threads:[~2015-07-31 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 15:45 git pull --upload-pack reversion in git 2.5.0 Joey Hess
2015-07-30 17:17 ` Matthieu Moy
2015-07-30 18:31   ` Joey Hess
2015-07-30 18:41     ` Junio C Hamano
2015-07-30 20:40       ` [PATCH] pull.sh: quote $upload_pack when passing it to git-fetch Matthieu Moy
2015-07-30 21:13         ` Junio C Hamano
2015-07-31 11:01         ` Paul Tan
2015-07-31 17:54       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk2tg5i2f.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=id@joeyh$(echo .)name \
    --cc=pyokagan@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox