From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Jean-Noel Avila <jn.avila@free•fr>, git@vger•kernel.org
Subject: Re: [PATCH] doc: fix unmatched code fences
Date: Tue, 12 May 2015 20:43:52 -0700 [thread overview]
Message-ID: <xmqqk2wdcfbb.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150513021556.GA4160@peff.net> (Jeff King's message of "Tue, 12 May 2015 22:15:56 -0400")
Jeff King <peff@peff•net> writes:
> With this patch and the one from Jean-Noel, the script above finds only
> one hit, which is a false positive. It's at git-commit.txt:233, and it
> looks like:
>
> It is a rough equivalent for:
> ------
> $ git reset --soft HEAD^
> $ ... do something else to come up with the right tree ...
> $ git commit -c ORIG_HEAD
>
> ------
>
> I have no idea how asciidoc knows that this is a code block and not a
> title called "It is a rough...".
It obviously is not a title underline as the lengths are vastly
different. It would be an interesing exercise to make both of them
longer, but I suspect giving an extra blank line there may not hurt.
Thanks, will queue.
next prev parent reply other threads:[~2015-05-13 3:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:23 [PATCH] doc: fix unmatched code fences Jean-Noel Avila
2015-05-12 18:45 ` Junio C Hamano
2015-05-13 2:15 ` Jeff King
2015-05-13 3:43 ` Junio C Hamano [this message]
2015-05-13 3:45 ` Jeff King
2015-05-13 4:32 ` Junio C Hamano
2015-05-13 4:36 ` Jeff King
2015-05-13 22:22 ` brian m. carlson
2015-05-13 4:56 ` [PATCH 0/8] asciidoc fixups Jeff King
2015-05-13 4:57 ` [PATCH 1/8] doc: fix misrendering due to `single quote' Jeff King
2015-05-13 4:58 ` [PATCH 2/8] doc: fix unquoted use of "{type}" Jeff King
2015-05-13 4:58 ` [PATCH 3/8] doc: fix hanging "+"-continuation Jeff King
2015-05-13 4:58 ` [PATCH 4/8] doc: fix length of underlined section-title Jeff King
2015-05-13 4:58 ` [PATCH 5/8] doc/add: reformat `--edit` option Jeff King
2015-05-13 5:01 ` [PATCH 6/8] doc: convert \--option to --option Jeff King
2015-05-13 9:48 ` John Keeping
2015-05-14 4:32 ` Jeff King
2015-05-17 18:34 ` Junio C Hamano
2015-05-13 5:02 ` [PATCH 7/8] doc: drop backslash quoting of some curly braces Jeff King
2015-05-13 5:06 ` [PATCH 8/8] doc: put example URLs and emails inside literal backticks Jeff King
2015-05-13 5:09 ` [PATCH 0/8] asciidoc fixups Jeff King
2015-05-13 5:23 ` Junio C Hamano
2015-05-13 5:37 ` Jeff King
2015-05-13 7:43 ` Johannes Schindelin
2015-05-14 4:29 ` Jeff King
2015-05-13 22:41 ` brian m. carlson
2015-05-14 4:25 ` Jeff King
2015-05-14 4:34 ` [PATCH 9/8] doc: convert AsciiDoc {?foo} to ifdef::foo[] Jeff King
2015-05-14 7:43 ` [PATCH 0/8] asciidoc fixups Johannes Schindelin
2015-05-14 17:38 ` Jeff King
2015-05-14 18:20 ` Johannes Schindelin
2015-05-14 21:10 ` Junio C Hamano
2015-05-14 21:17 ` Jeff King
2015-05-14 21:40 ` Junio C Hamano
2015-05-14 21:56 ` David Turner
2015-05-15 2:52 ` brian m. carlson
2015-05-15 4:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk2wdcfbb.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jn.avila@free$(echo .)fr \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox