From: Junio C Hamano <gitster@pobox•com>
To: David Turner <dturner@twopensource•com>
Cc: git@vger•kernel.org, mhagger@alum•mit.edu, neleai@seznam•cz,
David Turner <dturner@twitter•com>
Subject: Re: [PATCH v9] refs.c: SSE2 optimizations for check_refname_component
Date: Tue, 17 Jun 2014 10:35:43 -0700 [thread overview]
Message-ID: <xmqqk38fmob4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1402974642-13808-1-git-send-email-dturner@twitter.com> (David Turner's message of "Mon, 16 Jun 2014 23:10:42 -0400")
David Turner <dturner@twopensource•com> writes:
> git-compat-util.h | 11 +++
> refs.c | 223 ++++++++++++++++++++++++++++++++++++++++++++++++-----
> t/t5511-refspec.sh | 20 +++++
> 3 files changed, 236 insertions(+), 18 deletions(-)
Hmph, on what branch are you basing your patch? As a follow-up to
your dde8a902 (refs.c: optimize check_refname_component(),
2014-06-03) I originally tried to apply it on top of it but it does
not seem that the patch is based on that version; nor I have a blob
46139d2 on which the patch claims your refs.c changes are based on.
... goes and looks ...
Ahh, I think I know where it is broken.
> diff --git a/refs.c b/refs.c
> index 46139d2..5c2f68b 100644
> --- a/refs.c
> +++ b/refs.c
> ...
> @@ -46,17 +49,19 @@ static int check_refname_component(const char *refname, int flags)
> int ch = *cp & 255;
> unsigned char disp = refname_disposition[ch];
> switch(disp) {
There is a stylo here (missing SP after "switch"), which I already
have locally fixed before pushing it out on 'next'. I'll fix up
this patch and try to apply.
Thanks.
prev parent reply other threads:[~2014-06-17 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 3:10 [PATCH v9] refs.c: SSE2 optimizations for check_refname_component David Turner
2014-06-17 17:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk38fmob4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dturner@twitter$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=neleai@seznam$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox