From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Dave Borowitz <dborowitz@google•com>, git <git@vger•kernel.org>,
Erik Faye-Lund <kusmabite@gmail•com>
Subject: Re: [PATCH] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR
Date: Mon, 28 Apr 2014 14:27:18 -0700 [thread overview]
Message-ID: <xmqqk3a9no09.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140428205058.GQ9218@google.com> (Jonathan Nieder's message of "Mon, 28 Apr 2014 13:50:58 -0700")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Gah. Maybe it should be left-justified to avoid accentally breaking
> it again.
;-). Yes, $(error) is not the usual part of "to build this target,
follow this recipe" part.
But let's take the last round as-is and go with it for 2.0.
Tahnks.
next prev parent reply other threads:[~2014-04-28 21:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 19:50 [PATCH] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR Dave Borowitz
2014-04-28 20:05 ` Jonathan Nieder
2014-04-28 20:46 ` Dave Borowitz
2014-04-28 20:48 ` Dave Borowitz
2014-04-28 20:50 ` Jonathan Nieder
2014-04-28 20:52 ` Dave Borowitz
2014-04-28 21:27 ` Junio C Hamano [this message]
2014-04-28 21:04 ` Junio C Hamano
2014-04-28 20:45 ` Junio C Hamano
2014-04-28 20:56 ` Dave Borowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk3a9no09.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dborowitz@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=kusmabite@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox