From: Junio C Hamano <gitster@pobox•com>
To: Dave Borowitz <dborowitz@google•com>
Cc: Jonathan Nieder <jrnieder@gmail•com>, git <git@vger•kernel.org>,
Erik Faye-Lund <kusmabite@gmail•com>
Subject: Re: [PATCH] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR
Date: Mon, 28 Apr 2014 14:04:36 -0700 [thread overview]
Message-ID: <xmqqtx9dnp23.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAD0k6qR766hrgUtyiGzZ9KM5woknfsyUm3Mf1-Pm3M-LrL2Zhg@mail.gmail.com> (Dave Borowitz's message of "Mon, 28 Apr 2014 13:46:58 -0700")
Dave Borowitz <dborowitz@google•com> writes:
> On Mon, Apr 28, 2014 at 1:05 PM, Jonathan Nieder <jrnieder@gmail•com> wrote:
>> Dave Borowitz wrote:
>>
>>> Instead, if CURL_CONFIG is empty or returns an empty result (e.g. due
>>> to curl-config being missing), use the old behavior of falling back to
>>> -lcurl.
>>> ---
>>> Makefile | 36 +++++++++++++++++++++++++-----------
>>> 1 file changed, 25 insertions(+), 11 deletions(-)
>>
>> Sign-off?
>
> Oops.
Will forge your sign-off while queuing ;-)
>
> How about:
> "If CURL_CONFIG is unset or points to a binary that is not found,
> defaults to the CURLDIR behavior. If CURLDIR is not set, this means
> using -lcurl with no additional library detection (other than
> NEEDS_*_WITH_CURL).
... with this rephrasing.
>>> - $(error libcurl not detected; try setting CURLDIR)
>>> + $(error libcurl not detected or not compiled with static support)
>>
>> Whitespace damage.
>
> Yes, but intentional, because Makefile parsing is weird.
Thanks.
next prev parent reply other threads:[~2014-04-28 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 19:50 [PATCH] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR Dave Borowitz
2014-04-28 20:05 ` Jonathan Nieder
2014-04-28 20:46 ` Dave Borowitz
2014-04-28 20:48 ` Dave Borowitz
2014-04-28 20:50 ` Jonathan Nieder
2014-04-28 20:52 ` Dave Borowitz
2014-04-28 21:27 ` Junio C Hamano
2014-04-28 21:04 ` Junio C Hamano [this message]
2014-04-28 20:45 ` Junio C Hamano
2014-04-28 20:56 ` Dave Borowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx9dnp23.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dborowitz@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=kusmabite@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox