public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Eric Wong <normalperson@yhbt•net>
Cc: Uli Heller <uli.heller@daemons-point•com>,
	git@vger•kernel.org, "Kyle J. McKay" <mackyle@gmail•com>
Subject: Re: [PATCH] git-svn: Fix termination issues for remote svn connections
Date: Thu, 05 Sep 2013 16:14:52 -0700	[thread overview]
Message-ID: <xmqqk3iug8sz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20130905190249.GA1532@dcvr.yhbt.net> (Eric Wong's message of "Thu, 5 Sep 2013 19:02:49 +0000")

Eric Wong <normalperson@yhbt•net> writes:

> Junio C Hamano <gitster@pobox•com> wrote:
>> "Uli Heller" <uli.heller@daemons-point•com> writes:
>> > Nevertheless, I think it makes sense to fix the issue within the
>> > git perl module Ra.pm, too. The change frees the private copy of
>> > the remote access object on termination which prevents the error
>> > from happening.
>
>> Thanks.  Please sign-off your patch.
>> 
>> I am Cc'ing Kyle McKay who apparently had some experience working
>> with git-svn with newer svn that can only use serf, hoping that we
>> can get an independent opinion/test just to be sure.  Also Cc'ed is
>> Eric Wong who has been the official git-svn area expert, but I
>> understand that Eric hasn't needed to use git-svn for quite a while,
>> so it is perfectly fine if he does not have any comment on this one.
>> 
>> We may want to find a volunteer to move "git svn" forward as a new
>> area expert (aka subsystem maintainer), by the way.
>
> Correct, git-svn has the effect of being self-obsoleting.
>
> I agree with adding a workaround for broken things, however
> I suggest a code comment explaining why it is necessary.
> The commit message is important, too, but might get harder to track
> down if there's code movement/refactoring in the future.

Thanks for a good suggestion.  I agree that this addition is a good
example where in-code comment would really help the future readers.

>
>> > +END {
>> > +	$RA = undef;
>> > +	$ra_invalid = 1;
>> > +}

next prev parent reply	other threads:[~2013-09-05 23:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03  7:35 [PATCH] git-svn: Fix termination issues for remote svn connections Uli Heller
2013-09-05 18:48 ` Junio C Hamano
2013-09-05 19:02   ` Eric Wong
2013-09-05 23:14     ` Junio C Hamano [this message]
2013-09-06 11:46   ` Kyle J. McKay
2013-09-06 12:06     ` Uli Heller
2013-09-06 12:44       ` Kyle J. McKay
2013-09-06 13:18         ` Uli Heller
2013-09-06 16:41           ` Junio C Hamano
2013-09-09  6:01             ` [PATCH v2] " Uli Heller
2013-09-09 15:42               ` Junio C Hamano
2013-09-06 12:44   ` [PATCH] " Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqk3iug8sz.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mackyle@gmail$(echo .)com \
    --cc=normalperson@yhbt$(echo .)net \
    --cc=uli.heller@daemons-point$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox