public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Uli Heller" <uli.heller@daemons-point•com>
Cc: git@vger•kernel.org, "Kyle J. McKay" <mackyle@gmail•com>,
	Eric Wong <normalperson@yhbt•net>
Subject: Re: [PATCH] git-svn: Fix termination issues for remote svn connections
Date: Thu, 05 Sep 2013 11:48:54 -0700	[thread overview]
Message-ID: <xmqqli3bhzop.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <6970c0cab40c60195c8f042a3b930a0a.squirrel@83.236.132.106> (Uli Heller's message of "Tue, 3 Sep 2013 09:35:29 +0200 (CEST)")

"Uli Heller" <uli.heller@daemons-point•com> writes:

> When using git-svn in combination with serf-1.2.1 core dumps are
> created on termination. This is caused by a bug in serf, a fix for
> the bug exists (see https://code.google.com/p/serf/source/detail?r=2146).
> Nevertheless, I think it makes sense to fix the issue within the
> git perl module Ra.pm, too. The change frees the private copy of
> the remote access object on termination which prevents the error
> from happening.
>
> Note: Since subversion-1.8.0 and later do require serf-1.2.1 or later,
> the core dumps typically do show up when upgrading to a recent version
> of subversion.
>
> Credits: Jonathan Lambrechts for proposing a fix to Ra.pm.
> Evgeny Kotkov and Ivan Zhakov for fixing the issue in serf and
> pointing me to that fix.
> ---

Thanks.  Please sign-off your patch.

I am Cc'ing Kyle McKay who apparently had some experience working
with git-svn with newer svn that can only use serf, hoping that we
can get an independent opinion/test just to be sure.  Also Cc'ed is
Eric Wong who has been the official git-svn area expert, but I
understand that Eric hasn't needed to use git-svn for quite a while,
so it is perfectly fine if he does not have any comment on this one.

We may want to find a volunteer to move "git svn" forward as a new
area expert (aka subsystem maintainer), by the way.



>  perl/Git/SVN/Ra.pm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
> index 75ecc42..78dd346 100644
> --- a/perl/Git/SVN/Ra.pm
> +++ b/perl/Git/SVN/Ra.pm
> @@ -32,6 +32,11 @@ BEGIN {
>  	}
>  }
>
> +END {
> +	$RA = undef;
> +	$ra_invalid = 1;
> +}
> +
>  sub _auth_providers () {
>  	my @rv = (
>  	  SVN::Client::get_simple_provider(),

next prev parent reply	other threads:[~2013-09-05 18:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03  7:35 [PATCH] git-svn: Fix termination issues for remote svn connections Uli Heller
2013-09-05 18:48 ` Junio C Hamano [this message]
2013-09-05 19:02   ` Eric Wong
2013-09-05 23:14     ` Junio C Hamano
2013-09-06 11:46   ` Kyle J. McKay
2013-09-06 12:06     ` Uli Heller
2013-09-06 12:44       ` Kyle J. McKay
2013-09-06 13:18         ` Uli Heller
2013-09-06 16:41           ` Junio C Hamano
2013-09-09  6:01             ` [PATCH v2] " Uli Heller
2013-09-09 15:42               ` Junio C Hamano
2013-09-06 12:44   ` [PATCH] " Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqli3bhzop.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mackyle@gmail$(echo .)com \
    --cc=normalperson@yhbt$(echo .)net \
    --cc=uli.heller@daemons-point$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox