From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Kevin Willford <kcwillford@gmail•com>,
git@vger•kernel.org, Kevin Willford <kewillf@microsoft•com>
Subject: Re: [PATCH 2/2] rebase: turn on progress option by default for format-patch
Date: Sun, 04 Jun 2017 08:45:54 +0900 [thread overview]
Message-ID: <xmqqmv9ows7h.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170531221151.pxdikxgxy37g7zub@sigill.intra.peff.net> (Jeff King's message of "Wed, 31 May 2017 18:11:51 -0400")
Jeff King <peff@peff•net> writes:
> ...
> That explains why you want to pass "-q" in the other hunk; to
> countermand the explicit --progress here. But if we separate the two as
> I mentioned above, you'd want logic more like:
>
> if test -t 2 && test "$GIT_QUIET" != "t"
> git_format_patch_opt="$git_format_patch_opt --progress"
> fi
This looks like a sensible line of thought. Kevin, do you want to
try this again with the "explicit --progress option" approach? I
think the gist of the v1 review is that everybody agrees that the
end goal of showing a progress eye-candy from a long-running
"format-patch" phase in a "rebase" is a good idea, but it is dubious
"format-patch" should show it in cases other than when --progress is
explicitly asked for.
Thanks.
next prev parent reply other threads:[~2017-06-03 23:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 15:04 [PATCH 0/2] Add progress to format-patch and rebase Kevin Willford
2017-05-31 15:04 ` [PATCH 1/2] format-patch: have progress option while generating patches Kevin Willford
2017-05-31 18:40 ` Stefan Beller
2017-05-31 19:31 ` Kevin Willford
2017-05-31 22:01 ` Jeff King
2017-06-01 4:10 ` Junio C Hamano
2017-06-01 11:15 ` Johannes Schindelin
2017-06-01 15:54 ` Jeff King
2017-05-31 15:04 ` [PATCH 2/2] rebase: turn on progress option by default for format-patch Kevin Willford
2017-05-31 19:08 ` Stefan Beller
2017-05-31 19:46 ` Kevin Willford
2017-05-31 20:27 ` Stefan Beller
2017-06-01 11:11 ` Johannes Schindelin
2017-05-31 22:11 ` Jeff King
2017-06-03 23:45 ` Junio C Hamano [this message]
2017-08-10 18:32 ` [PATCH v2 0/2] Add progress for format-patch and rebase Kevin Willford
2017-08-10 22:48 ` Junio C Hamano
2017-08-10 23:17 ` Jeff King
2017-08-10 18:32 ` [PATCH v2 1/2] format-patch: have progress option while generating patches Kevin Willford
2017-08-10 23:20 ` Jeff King
2017-08-11 22:18 ` Junio C Hamano
2017-08-12 8:06 ` Philip Oakley
2017-08-13 4:39 ` Jeff King
2017-08-14 16:45 ` Junio C Hamano
2017-08-14 18:35 ` Junio C Hamano
2017-08-14 22:29 ` Jeff King
2017-08-14 22:42 ` Junio C Hamano
2017-08-14 23:08 ` Jeff King
2017-08-14 23:23 ` Junio C Hamano
2017-08-19 17:39 ` [PATCH] progress: simplify "delayed" progress API Junio C Hamano
2017-08-19 20:58 ` Junio C Hamano
2017-08-20 7:43 ` Jeff King
2017-08-10 18:32 ` [PATCH v2 2/2] rebase: turn on progress option by default for format-patch Kevin Willford
2017-08-11 22:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmv9ows7h.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kcwillford@gmail$(echo .)com \
--cc=kewillf@microsoft$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox