From: Junio C Hamano <gitster@pobox•com>
To: Gunnar Strand <gurra.strand@gmail•com>
Cc: git <git@vger•kernel.org>
Subject: Re: Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches
Date: Tue, 17 Dec 2013 10:00:57 -0800 [thread overview]
Message-ID: <xmqqob4fmk6e.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAEsF1LtJBA8gT9nEJv0_4CKRLGL7eWD19ghUGzQ9uWUCmj8X7w@mail.gmail.com> (Gunnar Strand's message of "Tue, 17 Dec 2013 10:59:14 +0100")
Gunnar Strand <gurra.strand@gmail•com> writes:
> The patch submission document has an inconsistency regarding who should be
> "To" and "Cc" for approved patches:
>
> To maintainer, cc list:
>
> 212 After the list reached a consensus that it is a good idea to apply the
> 213 patch, re-send it with "To:" set to the maintainer [*1*] and "cc:" the
> 214 list [*2*] for inclusion.
>
>
> To list, cc maintainer:
>
> 339 (4) The list forms consensus that the last round of your patch is
> 340 good. Send it to the list and cc the maintainer.
Thanks. In the latter, they are swapped.
Perhaps the whole section can be dropped? Back when the section was
written, the top section did not describe the review iteration and
lines 212-214 you quoted above did not exist, but the top section of
the current document already cover everything in the "ideal patch
flow" section, I think.
prev parent reply other threads:[~2013-12-17 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 9:59 Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches Gunnar Strand
2013-12-17 18:00 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqob4fmk6e.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gurra.strand@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox