* Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches
@ 2013-12-17 9:59 Gunnar Strand
2013-12-17 18:00 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Gunnar Strand @ 2013-12-17 9:59 UTC (permalink / raw)
To: git
Hi,
The patch submission document has an inconsistency regarding who should be
"To" and "Cc" for approved patches:
To maintainer, cc list:
212 After the list reached a consensus that it is a good idea to apply the
213 patch, re-send it with "To:" set to the maintainer [*1*] and "cc:" the
214 list [*2*] for inclusion.
To list, cc maintainer:
339 (4) The list forms consensus that the last round of your patch is
340 good. Send it to the list and cc the maintainer.
Ref 1:
https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L212
Ref 2:
https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L339
BR
Gunnar
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches
2013-12-17 9:59 Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches Gunnar Strand
@ 2013-12-17 18:00 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2013-12-17 18:00 UTC (permalink / raw)
To: Gunnar Strand; +Cc: git
Gunnar Strand <gurra.strand@gmail•com> writes:
> The patch submission document has an inconsistency regarding who should be
> "To" and "Cc" for approved patches:
>
> To maintainer, cc list:
>
> 212 After the list reached a consensus that it is a good idea to apply the
> 213 patch, re-send it with "To:" set to the maintainer [*1*] and "cc:" the
> 214 list [*2*] for inclusion.
>
>
> To list, cc maintainer:
>
> 339 (4) The list forms consensus that the last round of your patch is
> 340 good. Send it to the list and cc the maintainer.
Thanks. In the latter, they are swapped.
Perhaps the whole section can be dropped? Back when the section was
written, the top section did not describe the review iteration and
lines 212-214 you quoted above did not exist, but the top section of
the current document already cover everything in the "ideal patch
flow" section, I think.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-17 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 9:59 Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches Gunnar Strand
2013-12-17 18:00 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox