From: Junio C Hamano <gitster@pobox•com>
To: Krzesimir Nowak <krzesimir@endocode•com>
Cc: git@vger•kernel.org, jnareb@gmail•com, sunshine@sunshineco•com
Subject: Re: [PATCH 2/3] gitweb: Add a feature for adding more branch refs
Date: Tue, 03 Dec 2013 12:15:59 -0800 [thread overview]
Message-ID: <xmqqr49tn11c.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1386082603-8404-3-git-send-email-krzesimir@endocode.com> (Krzesimir Nowak's message of "Tue, 3 Dec 2013 15:56:42 +0100")
Krzesimir Nowak <krzesimir@endocode•com> writes:
> @@ -626,6 +640,17 @@ sub feature_avatar {
> return @val ? @val : @_;
> }
>
> +sub feature_extra_branch_refs {
> + my (@branch_refs) = @_;
> + my $values = git_get_project_config('extra_branch_refs');
Hmph. Three points.
* Almost all callers of this function use
my ($val) = git_get_project_config(...);
my @val = git_get_project_config(...);
to expect that the function returns a list of things (and grab the
first one among them, not the length of the list). Shoudln't this
part do the same?
* Wouldn't this be a good candidate for a multi-valued configuration
variable, e.g. shouldn't this
[gitweb]
extraBranchRefs = wip
extraBranchRefs = sandbox other
be parsed as a three-item list, qw(wip sandbox other)?
* I think the $key parameter to git_get_project_config() eventually
is used to look up a key in the Git-style configuration file, and
the 'words_with_underscore' goes against our convention (cf. see
how 'show-sizes' feature is spelled as 'showsizes' there).
> + if ($values) {
> + @branch_refs = split /\s+/, $values;
> + }
> +
> + return @branch_refs;
> +}
next prev parent reply other threads:[~2013-12-03 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 14:56 [PATCH 0/3] Show extra branch refs in gitweb Krzesimir Nowak
2013-12-03 14:56 ` [PATCH 1/3] gitweb: Move check-ref-format code into separate function Krzesimir Nowak
2013-12-03 19:02 ` Junio C Hamano
2013-12-03 19:38 ` Jakub Narębski
2013-12-03 19:48 ` Junio C Hamano
2013-12-04 13:06 ` Krzesimir Nowak
2013-12-03 14:56 ` [PATCH 2/3] gitweb: Add a feature for adding more branch refs Krzesimir Nowak
2013-12-03 18:51 ` Junio C Hamano
2013-12-03 20:15 ` Junio C Hamano [this message]
2013-12-03 20:38 ` Jakub Narębski
2013-12-04 12:49 ` Krzesimir Nowak
2013-12-04 17:57 ` Junio C Hamano
2013-12-03 14:56 ` [PATCH 3/3] gitweb: Denote non-heads, non-remotes branches Krzesimir Nowak
2013-12-04 13:44 ` [PATCH 0/3] Show extra branch refs in gitweb Krzesimir Nowak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr49tn11c.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=krzesimir@endocode$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox