From: Junio C Hamano <gitster@pobox•com>
To: "Jakub Narębski" <jnareb@gmail•com>
Cc: Krzesimir Nowak <krzesimir@endocode•com>,
git <git@vger•kernel.org>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH 1/3] gitweb: Move check-ref-format code into separate function
Date: Tue, 03 Dec 2013 11:48:09 -0800 [thread overview]
Message-ID: <xmqqzjohn2bq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CANQwDwd0_bgKfjsRFjohmzBAnN7vDm-pYYsfe0Q71Za2K7Hw4w@mail.gmail.com> ("Jakub Narębski"'s message of "Tue, 3 Dec 2013 20:38:39 +0100")
Jakub Narębski <jnareb@gmail•com> writes:
> Stricly speaking pure refactoring (no functional change, e.g. no assign
> to $input) would be "check_ref_format($input) or return undef;", or even
> "return check_ref_format($input);" if we keep check_ref_format() passthru
> on valid refname.
Exactly.
next prev parent reply other threads:[~2013-12-03 19:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 14:56 [PATCH 0/3] Show extra branch refs in gitweb Krzesimir Nowak
2013-12-03 14:56 ` [PATCH 1/3] gitweb: Move check-ref-format code into separate function Krzesimir Nowak
2013-12-03 19:02 ` Junio C Hamano
2013-12-03 19:38 ` Jakub Narębski
2013-12-03 19:48 ` Junio C Hamano [this message]
2013-12-04 13:06 ` Krzesimir Nowak
2013-12-03 14:56 ` [PATCH 2/3] gitweb: Add a feature for adding more branch refs Krzesimir Nowak
2013-12-03 18:51 ` Junio C Hamano
2013-12-03 20:15 ` Junio C Hamano
2013-12-03 20:38 ` Jakub Narębski
2013-12-04 12:49 ` Krzesimir Nowak
2013-12-04 17:57 ` Junio C Hamano
2013-12-03 14:56 ` [PATCH 3/3] gitweb: Denote non-heads, non-remotes branches Krzesimir Nowak
2013-12-04 13:44 ` [PATCH 0/3] Show extra branch refs in gitweb Krzesimir Nowak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzjohn2bq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=krzesimir@endocode$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox