From: Junio C Hamano <gitster@pobox•com>
To: Sebastian Schuberth <sschuberth@gmail•com>
Cc: Jeff King <peff@peff•net>, John Keeping <john@keeping•me.uk>,
Jonathan Nieder <jrnieder@gmail•com>,
Git Mailing List <git@vger•kernel.org>,
Karsten Blees <karsten.blees@gmail•com>
Subject: Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined
Date: Tue, 17 Sep 2013 14:46:46 -0700 [thread overview]
Message-ID: <xmqqsix3w27t.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAHGBnuMgE1zO4=MnJJXcDLJSD2Vsjptk1x2Bc6CpF9GSxmFp8w@mail.gmail.com> (Sebastian Schuberth's message of "Tue, 17 Sep 2013 21:16:13 +0200")
Sebastian Schuberth <sschuberth@gmail•com> writes:
> On Tue, Sep 17, 2013 at 6:17 PM, Junio C Hamano <gitster@pobox•com> wrote:
>
>> Keeping the ugliness to deal with the platform issue (i.e. broken
>> string.h) in one place (e.g. compat/mingw) is far more preferrable
>> than having a similar ugliness in git-compat-util.h for people on
>> all other platforms to see, no?
>
> I don't think people on other platforms seeing the ugliness is really
> an issue. After all, the file is called git-*compat*-util.h;
Well, judging from the way Linus reacted to the patch, I'd have to
disagree. After all, that argument leads to the position that
nothing is needed in compat/, no?
> Also, your solution does not really keep the ugliness in
> one place,...
One ugliness (lack of sane strcasecmp definition whose address can
be taken) specific to mingw is worked around in compat/mingw.h, and
another ugliness that some people may use compilers without include_next
may need help from another configuration in the Makefile to tell it
where the platform string.h resides. I am not sure why you see it
as a problem.
> I do insist to avoid GCC-ism in C files,...
To that I tend to agree. Unconditionally killing inlining for any
mingw compilation in compat/mingw.h may be the simplest (albeit it
may be less than optimal) solution.
next prev parent reply other threads:[~2013-09-17 21:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 16:06 [PATCH] git-compat-util: Avoid strcasecmp() being inlined Sebastian Schuberth
2013-09-11 18:29 ` Jonathan Nieder
2013-09-11 19:16 ` Jeff King
2013-09-19 6:04 ` Piotr Krukowiecki
[not found] ` <CAPc5daVt4Q9twub5KyOQqZHx9CwOnkuwA97sXV44fF2j1e5HVg@mail.gmail.com>
2013-09-19 9:47 ` Piotr Krukowiecki
2013-09-19 21:16 ` Jeff King
2013-09-19 22:03 ` Junio C Hamano
2013-09-19 22:05 ` Jeff King
2013-09-19 22:40 ` Junio C Hamano
2013-09-20 3:18 ` Jeff King
2013-09-20 6:21 ` Piotr Krukowiecki
2013-09-24 5:32 ` Jeff King
2013-09-11 19:59 ` Sebastian Schuberth
2013-09-11 21:41 ` Jeff King
2013-09-12 9:36 ` Sebastian Schuberth
2013-09-12 10:14 ` John Keeping
2013-09-12 15:37 ` Junio C Hamano
2013-09-12 18:20 ` Jeff King
2013-09-12 18:35 ` Junio C Hamano
2013-09-12 18:38 ` Jonathan Nieder
2013-09-12 19:51 ` Sebastian Schuberth
2013-09-12 20:08 ` Junio C Hamano
2013-09-13 12:33 ` Sebastian Schuberth
2013-09-13 14:26 ` Junio C Hamano
2013-09-13 19:34 ` Sebastian Schuberth
2013-09-12 21:36 ` Jonathan Nieder
2013-09-12 19:00 ` Jeff King
2013-09-12 19:46 ` Sebastian Schuberth
2013-09-12 20:22 ` Jeff King
2013-09-12 20:29 ` Junio C Hamano
2013-09-13 12:47 ` Sebastian Schuberth
2013-09-13 14:37 ` Junio C Hamano
2013-09-13 19:53 ` Sebastian Schuberth
2013-09-13 19:56 ` Linus Torvalds
2013-09-13 20:03 ` Sebastian Schuberth
2013-09-13 20:01 ` Junio C Hamano
2013-09-13 20:04 ` Sebastian Schuberth
2013-09-13 22:06 ` Junio C Hamano
2013-09-13 22:35 ` Junio C Hamano
2013-09-15 12:44 ` Sebastian Schuberth
2013-09-17 16:17 ` Junio C Hamano
2013-09-17 19:16 ` Sebastian Schuberth
2013-09-17 21:46 ` Junio C Hamano [this message]
2013-09-18 9:43 ` Sebastian Schuberth
2013-09-18 12:19 ` Linus Torvalds
2013-09-12 21:31 ` Jonathan Nieder
2013-09-19 13:47 ` Sebastian Schuberth
2013-09-11 18:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsix3w27t.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
--cc=jrnieder@gmail$(echo .)com \
--cc=karsten.blees@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sschuberth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox