From: Junio C Hamano <gitster@pobox•com>
To: Phil Hord <phil.hord@gmail•com>
Cc: Johannes Schindelin <johannes.schindelin@gmx•de>,
Phil Hord <hordp@cisco•com>, Git <git@vger•kernel.org>,
Fabian Ruch <bafain@gmail•com>
Subject: Re: [PATCH] rebase -i: redo tasks that die during cherry-pick
Date: Wed, 29 Apr 2015 12:41:24 -0700 [thread overview]
Message-ID: <xmqqtwvy4t97.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CABURp0odQWJC9LfQMywHKUarKAe7EY45fHET8xVVEsoBYDzBPg@mail.gmail.com> (Phil Hord's message of "Wed, 29 Apr 2015 15:32:33 -0400")
Phil Hord <phil.hord@gmail•com> writes:
> On Wed, Apr 29, 2015 at 1:15 PM, Junio C Hamano <gitster@pobox•com> wrote:
>>
>> Thanks, will queue.
>>
>> Aside from the "much more invasive" possibility, the patch makes me
>> wonder if it would have been a better design to have a static "todo"
>> with a "current" pointer as two state files. Then reschedule would
>> have been just the matter of decrementing the number in "current",
>> instead of "grab the last line of one file and prepend to the other
>> file, and then lose the last line".
>
> That's an interesting idea. Changing it now would impact anyone who
> now depends on the current todo/done behavior, and I imagine there
> are many.
Yeah, in case it wasn't clear, I was merely lamenting over water
under the bridge, not seriously suggesting to break users to
simplify our logic.
next prev parent reply other threads:[~2015-04-29 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 22:55 [PATCH] rebase -i: redo tasks that die during cherry-pick Phil Hord
2015-04-28 23:17 ` Johannes Schindelin
2015-04-29 17:15 ` Junio C Hamano
2015-04-29 19:32 ` Phil Hord
2015-04-29 19:41 ` Junio C Hamano [this message]
2015-04-30 7:49 ` rebase -i's todo/done list, was " Johannes Schindelin
2015-04-30 9:54 ` Fabian Ruch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwvy4t97.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bafain@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hordp@cisco$(echo .)com \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=phil.hord@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox