From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Trevor Saunders <tbsaunde@tbsaunde•org>,
git@vger•kernel.org,
Christian Couder <christian.couder@gmail•com>
Subject: Re: [PATCH v2] bisect: improve output when bad commit is found
Date: Tue, 12 May 2015 22:48:36 -0700 [thread overview]
Message-ID: <xmqqvbfxauyz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150513013637.GB3066@peff.net> (Jeff King's message of "Tue, 12 May 2015 21:36:37 -0400")
Jeff King <peff@peff•net> writes:
> Of course, that is not a guarantee that nobody scraped stderr, but at
> least it makes me feel better that they're Doing It Wrong. :)
>
> It would be nice if we had some actual data points. I followed the link
> Christian gave to Ingo's old post, but I didn't see the actual script
> there. There is:
>
> https://github.com/grosser/git-autobisect/blob/master/lib/git/autobisect.rb
>
> which does seem to scrape stderr. Bleh.
Heh, anything ending with .rb is a bleh to me ;-)
>> So perhaps if we keep
>>
>> <40 char sha1> is the first bad commit
>>
>> and then replace the diff-tree output with "show -s", then the
>> result would be good enough, I would say.
>
> That seems like a reasonable first step, at the very least. I wonder if
> we should also better document the exit code and BISECT_LOG semantics,
> and explicitly tell people not to scrape stderr.
Yeah, that would also be a good first step, whichever comes first.
next prev parent reply other threads:[~2015-05-13 5:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 23:19 [PATCH v2] bisect: improve output when bad commit is found Trevor Saunders
2015-05-12 23:24 ` Junio C Hamano
2015-05-13 0:54 ` Trevor Saunders
2015-05-13 1:13 ` Junio C Hamano
2015-05-13 1:36 ` Jeff King
2015-05-13 5:48 ` Junio C Hamano [this message]
2015-05-13 9:39 ` Christian Couder
2015-05-13 21:42 ` Jeff King
2015-05-13 9:10 ` Christian Couder
2015-05-13 17:25 ` Trevor Saunders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbfxauyz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=tbsaunde@tbsaunde$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox