public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Trevor Saunders <tbsaunde@tbsaunde•org>
Cc: git@vger•kernel.org, Christian Couder <christian.couder@gmail•com>
Subject: Re: [PATCH v2] bisect: improve output when bad commit is found
Date: Tue, 12 May 2015 16:24:00 -0700	[thread overview]
Message-ID: <xmqqwq0dcrcf.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1431472751-20974-1-git-send-email-tbsaunde@tbsaunde.org> (Trevor Saunders's message of "Tue, 12 May 2015 19:19:11 -0400")

Trevor Saunders <tbsaunde@tbsaunde•org> writes:

> When the first bad commit has been found git bisect prints something
> like this:
>
> 	<40 char sha1> is the first bad commit
> 	Commit <40 char sha1>
> 	...
>
> 	:100644 100644 10f5e57... a46cfeb... M  bisect.c
> 	:100755 100755 ae3fec2... 65a19fa... M  git-bisect.sh
>
> The raw diff output is not really useful, and its kind of silly to print
> the sha1 twice.  Instead lets print something like this:
>
> 	The first bad commit is
> 	Commit <sha1>
> 	...

According to +CCouder, this change will break existing people's use
cases.

See $gmane/268881

  reply	other threads:[~2015-05-12 23:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 23:19 [PATCH v2] bisect: improve output when bad commit is found Trevor Saunders
2015-05-12 23:24 ` Junio C Hamano [this message]
2015-05-13  0:54   ` Trevor Saunders
2015-05-13  1:13     ` Junio C Hamano
2015-05-13  1:36       ` Jeff King
2015-05-13  5:48         ` Junio C Hamano
2015-05-13  9:39         ` Christian Couder
2015-05-13 21:42           ` Jeff King
2015-05-13  9:10       ` Christian Couder
2015-05-13 17:25         ` Trevor Saunders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwq0dcrcf.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tbsaunde@tbsaunde$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox