* [PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list
@ 2025-10-24 15:15 QueenJcloud
2025-10-24 16:02 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: QueenJcloud @ 2025-10-24 15:15 UTC (permalink / raw)
To: git; +Cc: christian.couder, usmanakinyemi202, qjessa662
After explaining how to send patches using `git send-email`, add a helpful tip
for contributors on how to confirm that their patches were successfully sent
and appeared on the mailing list. This provides reassurance for newcomers and
helps them verify their submission.
Signed-off-by: Queen Ediri Jessa <qjessa662@gmail•com>
---
Documentation/MyFirstContribution.adoc | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index 02ba8ba5f6..94acdaeddd 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -1158,6 +1158,13 @@ prompt for each patch that's about to go out. This gives you one last chance to
edit or quit sending something (but again, don't edit code this way). Once you
press `y` or `a` at these prompts your emails will be sent! Congratulations!
+[TIP]
+====
+After sending your patches, you can confirm that they reached the mailing list
+by visiting https://lore.kernel.org/git/. Use the search bar to find your name
+or the subject of your patch. If it appears, your email was successfully delivered.
+====|
+
Awesome, now the community will drop everything and review your changes. (Just
kidding - be patient!)
--
2.51.0.573.gb660e2dcb9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list
2025-10-24 15:15 [PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list QueenJcloud
@ 2025-10-24 16:02 ` Junio C Hamano
2025-10-24 21:04 ` [PATCH v2] MyFirstContribution: add note on confirming patches QueenJcloud
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2025-10-24 16:02 UTC (permalink / raw)
To: QueenJcloud; +Cc: git, christian.couder, usmanakinyemi202
QueenJcloud <qjessa662@gmail•com> writes:
> After explaining how to send patches using `git send-email`, add a helpful tip
> for contributors on how to confirm that their patches were successfully sent
> and appeared on the mailing list. This provides reassurance for newcomers and
> helps them verify their submission.
This is a bit wider than desirable; it will bust 80-column limit
when quoted twice in a discussion thread.
> Signed-off-by: Queen Ediri Jessa <qjessa662@gmail•com>
> ---
> Documentation/MyFirstContribution.adoc | 7 +++++++
> 1 file changed, 7 insertions(+)
We want to see that author identity and the identity on Sign-off
match. I can tweak the author identity on our end for this patch,
but if you are going to send further patches please make sure that
your [user] name = "..." configuration is what you wrote on the
Sign-off line.
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 02ba8ba5f6..94acdaeddd 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1158,6 +1158,13 @@ prompt for each patch that's about to go out. This gives you one last chance to
> edit or quit sending something (but again, don't edit code this way). Once you
> press `y` or `a` at these prompts your emails will be sent! Congratulations!
>
> +[TIP]
> +====
> +After sending your patches, you can confirm that they reached the mailing list
> +by visiting https://lore.kernel.org/git/. Use the search bar to find your name
> +or the subject of your patch. If it appears, your email was successfully delivered.
> +====|
> +
Use of [TIP] is new (we seem to use only [NOTE] adminition blocks in
the existing text). After reading the part before this hunk, the
structure of the section is
(title -- sending email)
It's time to mail it out, with this command
$ git send-email ...
[note] ...
[note] ...
[note] ...
After you run the command above, you will be presented with a prompt...
And you are adding a [tip] _after_ that, but the existing notes are
also about tips to use "git send-email" correctly. It is not like
existing explanation "After you run ..." is exactly correct. When
you get prompted, the command hasn't finished running. It merely is
"after you type the command and hit return".
I am tempted to move that "After you run..." sentence up and above
these three [note] admonition blocks (and rephrase it a bit, perhaps
with "After" -> "When"). Then add this new piece as the fourth [note].
What's the vertical bar "|" after the closing example block
delimiter (i.e. the second "====")? I'll drop it as otherwise
Asciidoctor complains
asciidoctor: WARNING: MyFirstContribution.adoc: line 1162: unterminated admonition block
and makes the rest of the document part of this [TIP].
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] MyFirstContribution: add note on confirming patches
2025-10-24 16:02 ` Junio C Hamano
@ 2025-10-24 21:04 ` QueenJcloud
2025-10-27 8:45 ` Christian Couder
0 siblings, 1 reply; 4+ messages in thread
From: QueenJcloud @ 2025-10-24 21:04 UTC (permalink / raw)
To: gitster; +Cc: christian.couder, git, qjessa662, usmanakinyemi202
Add a note after the `git send-email` section explaining how
contributors can confirm that their patches reached the mailing
list by checking https://lore.kernel.org/git/.
Signed-off-by: QueenJcloud <qjessa662@gmail•com>
---
Documentation/MyFirstContribution.adoc | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index 02ba8ba5f6..6e7f3036bb 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger•kernel.org - but
please don't send your patchset from the tutorial to the real mailing list! For
now, you can send it to yourself, to make sure you understand how it will look.
+NOTE: After sending your patches, you can confirm that they reached the mailing
+list by visiting https://lore.kernel.org/git/. Use the search bar to find your
+name or the subject of your patch. If it appears, your email was successfully
+delivered.
+
After you run the command above, you will be presented with an interactive
prompt for each patch that's about to go out. This gives you one last chance to
edit or quit sending something (but again, don't edit code this way). Once you
press `y` or `a` at these prompts your emails will be sent! Congratulations!
+
Awesome, now the community will drop everything and review your changes. (Just
kidding - be patient!)
--
2.51.0.573.gb660e2dcb9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] MyFirstContribution: add note on confirming patches
2025-10-24 21:04 ` [PATCH v2] MyFirstContribution: add note on confirming patches QueenJcloud
@ 2025-10-27 8:45 ` Christian Couder
0 siblings, 0 replies; 4+ messages in thread
From: Christian Couder @ 2025-10-27 8:45 UTC (permalink / raw)
To: QueenJcloud; +Cc: gitster, git, usmanakinyemi202
On Fri, Oct 24, 2025 at 11:04 PM QueenJcloud <qjessa662@gmail•com> wrote:
>
> Add a note after the `git send-email` section explaining how
> contributors can confirm that their patches reached the mailing
> list by checking https://lore.kernel.org/git/.
>
> Signed-off-by: QueenJcloud <qjessa662@gmail•com>
Are you sure that "QueenJcloud" is the best way to identify you? We
prefer a real name if possible, and yeah it should match the name
associated with your email address.
Documentation/SubmittingPatches has the following about this:
"[[real-name]]
Please use a known identity in the `Signed-off-by` trailer, since we cannot
accept anonymous contributions. It is common, but not required, to use some form
of your real name. We realize that some contributors are not comfortable doing
so or prefer to contribute under a pseudonym or preferred name and we can accept
your patch either way, as long as the name and email you use are distinctive,
identifying, and not misleading.
The goal of this policy is to allow us to have sufficient information to contact
you if questions arise about your contribution."
> ---
This is a v2 patch, so it would be nice to know what changed since the
previous version of the patch. It could be added here after the line
with three dashes ("---").
Also it looks like this v2 patch was sent twice.
> Documentation/MyFirstContribution.adoc | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 02ba8ba5f6..6e7f3036bb 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger•kernel.org - but
> please don't send your patchset from the tutorial to the real mailing list! For
> now, you can send it to yourself, to make sure you understand how it will look.
>
> +NOTE: After sending your patches, you can confirm that they reached the mailing
> +list by visiting https://lore.kernel.org/git/. Use the search bar to find your
> +name or the subject of your patch. If it appears, your email was successfully
> +delivered.
This looks good to me.
> After you run the command above, you will be presented with an interactive
> prompt for each patch that's about to go out. This gives you one last chance to
> edit or quit sending something (but again, don't edit code this way). Once you
> press `y` or `a` at these prompts your emails will be sent! Congratulations!
>
> +
It looks like there is a spurious new line here. Please remove it.
> Awesome, now the community will drop everything and review your changes. (Just
> kidding - be patient!)
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-27 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-24 15:15 [PATCH] MyFirstContribution: add tip for confirming patches reached the mailing list QueenJcloud
2025-10-24 16:02 ` Junio C Hamano
2025-10-24 21:04 ` [PATCH v2] MyFirstContribution: add note on confirming patches QueenJcloud
2025-10-27 8:45 ` Christian Couder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox