From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: "René Scharfe" <l.s.r@web•de>,
"Johannes Schauer" <josch@debian•org>,
"Git List" <git@vger•kernel.org>
Subject: Re: [PATCH 1/3] t5004: test ZIP archives with many entries
Date: Fri, 28 Aug 2015 08:45:39 -0700 [thread overview]
Message-ID: <xmqqwpwf2z8c.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAPig+cSNSfpt7gOLvz7P4oDrNF5fTQ38v1pfncJU3h7a6FjMyQ@mail.gmail.com> (Eric Sunshine's message of "Sun, 23 Aug 2015 13:45:26 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> On Sun, Aug 23, 2015 at 5:29 AM, "René Scharfe" <l.s.r@web•de> wrote:
>> I suspected that zipinfo's output might be formatted differently on
>> different platforms and tried to guard against it by checking for the
>> number zero there. Git's ZIP file creation is platform independent
>> (modulo bugs), so having a test run at least somewhere should
>> suffice. In theory.
>>
>> We could add support for the one-line-summary variant on OS X easily,
>> though.
>
> Probably, although it's looking like testing on Mac OS X won't be
> fruitful (see below).
Can we move this topic forward by introducing a new prerequisite
ZIPINFO and used at the beginning of these tests (make it a lazy
prereq)? Run zipinfo on a trivial archive and see if its output is
something we recognize to decide if the platform supports that
ZIPINFO prerequisite and do this test only on them.
After all, what _is_ being tested, i.e. our archive creation, would
not change across platforms, so having a test that runs on a known
subset of platforms is better than not having anything at all.
Thanks.
next prev parent reply other threads:[~2015-08-28 15:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 10:40 bug: git-archive does not use the zip64 extension for archives with more than 16k entries Johannes Schauer
2015-08-12 19:40 ` René Scharfe
2015-08-13 2:25 ` Johannes Schauer
2015-08-22 19:06 ` [PATCH 1/3] t5004: test ZIP archives with many entries René Scharfe
2015-08-23 5:54 ` Eric Sunshine
2015-08-23 9:29 ` "René Scharfe"
2015-08-23 9:35 ` Eric Sunshine mail delivery failure René Scharfe
2015-08-23 17:16 ` Johannes Löthberg
2015-08-23 18:24 ` Eric Sunshine
[not found] ` <CA+EOSBmk2cdQe3owaXgkYAgTZqpUFa=J8g5FYq28-=VhDcJ4EA@mail.gmail.com>
2015-08-23 18:48 ` Eric Sunshine
2015-08-23 18:57 ` Eric Sunshine
2015-08-23 17:45 ` [PATCH 1/3] t5004: test ZIP archives with many entries Eric Sunshine
2015-08-28 15:45 ` Junio C Hamano [this message]
2015-08-28 15:57 ` Junio C Hamano
2015-08-28 16:47 ` Eric Sunshine
2015-08-22 19:06 ` [PATCH 2/3] archive-zip: use a local variable to store the creator version René Scharfe
2015-08-22 19:06 ` [PATCH 3/3] archive-zip: support more than 65535 entries René Scharfe
2015-08-15 8:40 ` bug: git-archive does not use the zip64 extension for archives with more than 16k entries Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpwf2z8c.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=josch@debian$(echo .)org \
--cc=l.s.r@web$(echo .)de \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox