public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Paul Tan <pyokagan@gmail•com>
Cc: Eric Sunshine <sunshine@sunshineco•com>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
	Git List <git@vger•kernel.org>, Jeff King <peff@peff•net>
Subject: Re: [PATCH v5 3/3] t0302: test credential-store support for XDG_CONFIG_HOME
Date: Wed, 25 Mar 2015 09:17:34 -0700	[thread overview]
Message-ID: <xmqqwq252grl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cQ-yLnjrsB1E-7=UXfGzuJHat6YtfS8EVRNP2dcjj_6TA@mail.gmail.com> (Eric Sunshine's message of "Wed, 25 Mar 2015 02:54:42 -0400")

Eric Sunshine <sunshine@sunshineco•com> writes:

> On Tue, Mar 24, 2015 at 5:52 AM, Matthieu Moy
> ...
>> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag•fr>
>
> With the POSIXPERM issue[1] addressed (if necessary), patch 3/3 is also:
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco•com>

THanks for a review.  Paul, the 3-patch series is already in 'next',
so please fix these up with a follow-up patch.

Thanks.

next prev parent reply	other threads:[~2015-03-25 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  5:20 [PATCH v5 1/3] git-credential-store: support multiple credential files Paul Tan
2015-03-24  5:20 ` [PATCH v5 2/3] git-credential-store: support XDG_CONFIG_HOME Paul Tan
2015-03-24  5:20 ` [PATCH v5 3/3] t0302: test credential-store support for XDG_CONFIG_HOME Paul Tan
2015-03-24  9:52   ` Matthieu Moy
2015-03-25  6:54     ` Eric Sunshine
2015-03-25 16:17       ` Junio C Hamano [this message]
2015-03-25 20:25         ` Junio C Hamano
2015-03-26  5:20           ` Paul Tan
2015-03-26 13:27             ` Matthieu Moy
2015-03-25  6:42   ` Eric Sunshine
2015-03-25 19:03     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwq252grl.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=pyokagan@gmail$(echo .)com \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox