From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Paul Tan <pyokagan@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Jeff King <peff@peff•net>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH v5 3/3] t0302: test credential-store support for XDG_CONFIG_HOME
Date: Tue, 24 Mar 2015 10:52:00 +0100 [thread overview]
Message-ID: <vpqbnjivi2n.fsf@anie.imag.fr> (raw)
In-Reply-To: <1427174429-5876-3-git-send-email-pyokagan@gmail.com> (Paul Tan's message of "Tue, 24 Mar 2015 13:20:29 +0800")
Paul Tan <pyokagan@gmail•com> writes:
> Matthieu and Eric: I know I said I will try to re-order the patches to
> put the tests before the implementation, but after thinking and trying
> to rewrite the commit messages I realised it seems really weird to me.
> In this patch series, the implementation is split across the first two
> patches. The first patch should use the old tests, and ideally, the new
> tests should be squashed with the second patch because it seems more
> logical to me to implement the tests at the same time as the new
> feature. However, since the tests patch is very long, to make it easier
> to review it is split into a separate patch which is applied after the
> implementation patches.
No problem, your version is very good. I was pointing out alternatives,
but not requesting a change, and your reasoning makes perfect sense.
I had reviewed v4 in details, and checked the diff between v4 and v5.
The whole series is now
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag•fr>
Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-03-24 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 5:20 [PATCH v5 1/3] git-credential-store: support multiple credential files Paul Tan
2015-03-24 5:20 ` [PATCH v5 2/3] git-credential-store: support XDG_CONFIG_HOME Paul Tan
2015-03-24 5:20 ` [PATCH v5 3/3] t0302: test credential-store support for XDG_CONFIG_HOME Paul Tan
2015-03-24 9:52 ` Matthieu Moy [this message]
2015-03-25 6:54 ` Eric Sunshine
2015-03-25 16:17 ` Junio C Hamano
2015-03-25 20:25 ` Junio C Hamano
2015-03-26 5:20 ` Paul Tan
2015-03-26 13:27 ` Matthieu Moy
2015-03-25 6:42 ` Eric Sunshine
2015-03-25 19:03 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqbnjivi2n.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=pyokagan@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox